[Entitlements] Add a check for filesystem mismatch #123744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
added
>non-issue
auto-backport
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
This was referenced Feb 28, 2025
rjernst
approved these changes
Feb 28, 2025
| } | ||
|
|
||
| private boolean checkPath(String path, String[] paths) { | ||
| logger.debug(() -> Strings.format("checking [%s] against [%s]", path, String.join(",", paths))); |
There was a problem hiding this comment.
This seems more trace level? It could be extremely verbose?
There was a problem hiding this comment.
Sorry, I always mix them up! I will fix all 3 of them
| } | ||
|
|
||
| private static boolean isParent(String maybeParent, String path) { | ||
| logger.debug(() -> Strings.format("checking isParent [%s] for [%s]", maybeParent, path)); |
There was a problem hiding this comment.
Same here, this could log a lot.
|
Removing test-windows as it still fails until we merge #123689 (and we need this to merge it) |
This was referenced Feb 28, 2025
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Feb 28, 2025
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Feb 28, 2025
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Feb 28, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 1, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 1, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 1, 2025
This was referenced Mar 5, 2025
Merged
Merged
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NIO Files function accept an arbitrary Path object; this objects may be of different classes/come from FileSystems different from the default one, which is the one that provide access to the file systems accessible to the Java virtual machine, and which we are trying to protect.
For example: you can pass a
ZipPath(created by aZipFileSystem) toFiles.exists(Path), to check for contents of a Zip file. This works, but check for entitlements on thatZipPathis not correct.While checking for Files entitlements, we should skip checks on Paths coming from different FileSystems, as they do not intersect with the Paths we are protecting. This PR adds a condition to do that.