Skip to content

Comment on disabling compression when using HTTPS #123877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2025
Merged

Comment on disabling compression when using HTTPS #123877

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
219eda5
Comment on disabling compression when using HTTPS
DaveCTurner Mar 3, 2025
c2c8462
Merge branch 'main' into 2025/03/03/https-compression-comment
DaveCTurner Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...curity/src/main/java/org/elasticsearch/xpack/security/transport/SecurityHttpSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ public final class SecurityHttpSettings {
private SecurityHttpSettings() {}

public static void overrideSettings(Settings.Builder settingsBuilder, Settings settings) {
// HTTP response compression over TLS risks side-channel vulnerabilities such as BREACH[1] if ES is used in very specific ways. We
// cannot be sure that ES is not being used in such a manner here, so we disable compression by default when TLS is enabled for the
// REST layer and rely on the user explicitly setting `http.compression: true` to confirm that they do not have a vulnerable
// usage pattern.
//
// [1] https://www.breachattack.com/
if (HTTP_SSL_ENABLED.get(settings) && SETTING_HTTP_COMPRESSION.exists(settings) == false) {
settingsBuilder.put(SETTING_HTTP_COMPRESSION.getKey(), false);
}
Expand Down