Grant read access to the config dir #123882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches what Security Manager permissions Elasticsearch had for all plugins.
rjernst
added
>refactoring
auto-backport
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
prdoyle
approved these changes
Mar 3, 2025
ldematte
reviewed
Mar 3, 2025
| // everything has access to the temp dir and the jdk | ||
| // everything has access to the temp dir, config dir and the jdk | ||
| addPathAndMaybeLink.accept(pathLookup.tempDir(), Mode.READ_WRITE); | ||
| addPathAndMaybeLink.accept(pathLookup.configDir(), Mode.READ); |
There was a problem hiding this comment.
Do you want this to be permanent, or a stop-gap solution until we figure out the policy files?
If it's the latter, can you add a TODO comment please?
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 3, 2025
This matches what Security Manager permissions Elasticsearch had for all plugins.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 3, 2025
This matches what Security Manager permissions Elasticsearch had for all plugins.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 3, 2025
This matches what Security Manager permissions Elasticsearch had for all plugins.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 3, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 3, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 4, 2025
This matches what Security Manager permissions Elasticsearch had for all plugins. Co-authored-by: Elastic Machine <[email protected]>
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
This matches what Security Manager permissions Elasticsearch had for all plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches what Security Manager permissions Elasticsearch had for all plugins.