Use IDENTITY constants when creating stats in TrainedModelsStatsAction #123894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
davidkyle
reviewed
Mar 5, 2025
...ml/src/main/java/org/elasticsearch/xpack/ml/action/TransportGetTrainedModelsStatsAction.java
Outdated
Show resolved
Hide resolved
...ml/src/main/java/org/elasticsearch/xpack/ml/action/TransportGetTrainedModelsStatsAction.java
Outdated
Show resolved
Hide resolved
…on/TransportGetTrainedModelsStatsAction.java Co-authored-by: David Kyle <[email protected]>
iverase
added
the
auto-backport
This was referenced Mar 6, 2025
Merged
Collaborator
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Mar 6, 2025
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Mar 6, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 6, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 6, 2025
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
costin
pushed a commit
to costin/elasticsearch
that referenced
this pull request
Mar 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some identity constants to define empty stats. Let's use them for consistency in TrainedModelStatsAction and be nicer to heap usage.