Skip to content

Add jdk.management.agent module to server boot layer on start #123938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 4, 2025
Merged

Add jdk.management.agent module to server boot layer on start #123938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
30efcc6
Correctly identify system modules not included in boot module layer
mark-vieira Mar 3, 2025
275efd3
Merge branch 'main' into simplify-system-module-detection
mark-vieira Mar 4, 2025
1b69de3
Add jdk.management.agent module to server
mark-vieira Mar 4, 2025
2eb55da
Extend column size so command line isn't truncated
mark-vieira Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ion/tools/server-cli/src/main/java/org/elasticsearch/server/cli/ServerProcessBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ private List<String> getJvmArgs() {
esHome.resolve("lib").toString(),
// Special circumstances require some modules (not depended on by the main server module) to be explicitly added:
"--add-modules=jdk.net", // needed to reflectively set extended socket options
"--add-modules=jdk.management.agent", // needed by external debug tools to grab thread and heap dumps
// we control the module path, which may have additional modules not required by server
"--add-modules=ALL-MODULE-PATH",
"-m",
Expand Down
2 changes: 1 addition & 1 deletion qa/packaging/src/test/java/org/elasticsearch/packaging/util/docker/Docker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ public static void waitForElasticsearchToStart() {
Thread.sleep(STARTUP_SLEEP_INTERVAL_MILLISECONDS);

// Set COLUMNS so that `ps` doesn't truncate its output
psOutput = dockerShell.run("bash -c 'COLUMNS=2000 ps ax'").stdout();
psOutput = dockerShell.run("bash -c 'COLUMNS=3000 ps ax'").stdout();

if (psOutput.contains("org.elasticsearch.bootstrap.Elasticsearch")) {
isElasticsearchRunning = true;
Expand Down