Fix wording on node roles #123939
Merged
Fix wording on node roles #123939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the 8.17 docs there is a statement that intends to say that nodes without roles are coordinating-only nodes. However, the wording was misleading because it referred to leaving the setting _unset_ rather than explictly setting it to _empty_.
tvernum
added
>docs
|
Documentation preview: |
|
Pinging @elastic/es-docs (Team:Docs) |
elasticsearchmachine
added
Team:Docs
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
shainaraskas
approved these changes
Mar 4, 2025
shainaraskas
added a commit
that referenced
this pull request
Mar 4, 2025
Port change #123939 forward to new docs system
shainaraskas
added a commit
that referenced
this pull request
Mar 5, 2025
* Update node-settings.md Port change #123939 forward to new docs system * Update docs/reference/elasticsearch/configuration-reference/node-settings.md
leemthompo
pushed a commit
to leemthompo/elasticsearch
that referenced
this pull request
Mar 6, 2025
* Update node-settings.md Port change elastic#123939 forward to new docs system * Update docs/reference/elasticsearch/configuration-reference/node-settings.md (cherry picked from commit a06c8ea)
leemthompo
added a commit
that referenced
this pull request
Mar 6, 2025
* Update node-settings.md Port change #123939 forward to new docs system * Update docs/reference/elasticsearch/configuration-reference/node-settings.md (cherry picked from commit a06c8ea) Co-authored-by: shainaraskas <[email protected]>
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
* Update node-settings.md Port change elastic#123939 forward to new docs system * Update docs/reference/elasticsearch/configuration-reference/node-settings.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the 8.17 docs there is a statement that intends to say that nodes without roles are coordinating-only nodes. However, the wording was misleading because it referred to leaving the setting unset rather than explicitly setting it to empty.