[profiling] Take care of @UpdateForV9 #123977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockdaboot
added
>non-issue
:UniversalProfiling/Application
elasticsearchmachine
added
the
Team:obs-ux-infra_services
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
elasticsearchmachine
added
the
external-contributor
rockdaboot
commented
Mar 4, 2025
| private final int size; | ||
| private final double samplingRate; | ||
| private final long selfCPU; | ||
| @UpdateForV9(owner = UpdateForV9.Owner.PROFILING) // remove this field - it is unused in Kibana |
There was a problem hiding this comment.
totalCPU is still used in Kibana, removed annotation
rockdaboot
commented
Mar 4, 2025
| @UpdateForV9(owner = UpdateForV9.Owner.PROFILING) // remove this field - it is unused in Kibana | ||
| private final long totalCPU; | ||
| @UpdateForV9(owner = UpdateForV9.Owner.PROFILING) // remove this field - it is unused in Kibana | ||
| private final long totalSamples; |
There was a problem hiding this comment.
`totalSamples is still used in Kibana, removed annotation.
rockdaboot
commented
Mar 4, 2025
| private final String name; | ||
| private Long count; | ||
| @UpdateForV9(owner = UpdateForV9.Owner.PROFILING) // remove legacy XContent rendering | ||
| @UpdateForV10(owner = UpdateForV10.Owner.PROFILING) // remove legacy XContent rendering |
There was a problem hiding this comment.
Unclear why XContent is legacy. The API isn't deprecated. The profiling team hasn't any further knowledge.
arpadkiraly
added
the
auto-backport
christos68k
approved these changes
Mar 4, 2025
| @Nullable | ||
| private final Map<String, TraceEvent> stackTraceEvents; | ||
| @UpdateForV9(owner = UpdateForV9.Owner.PROFILING) // remove this field - it is unused in Kibana | ||
| private final int totalFrames; |
There was a problem hiding this comment.
Do we still need to keep this around?
There was a problem hiding this comment.
Yes. Sorry, I put the comment at the wrong place:
totalFrames is still used in internally to calculate sizes for map allocations. Removed sending the value as total_frames to Kibana, where it isn't used any more.`
rockdaboot
added a commit
to rockdaboot/elasticsearch
that referenced
this pull request
Mar 5, 2025
* [profiling] Take care of @UpdateForV9 * Fix GetStackTracesResponseTests
rockdaboot
added a commit
to rockdaboot/elasticsearch
that referenced
this pull request
Mar 5, 2025
* [profiling] Take care of @UpdateForV9 * Fix GetStackTracesResponseTests
rockdaboot
added a commit
that referenced
this pull request
Mar 5, 2025
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
* [profiling] Take care of @UpdateForV9 * Fix GetStackTracesResponseTests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@UpdateForV9annotation where it was wrongly set@UpdateForV9to@UpdateForV10where required (added explanations)