Simplify Lucene60 and Luene62 codec constructors #124054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only public constructor needed in the archive index codecs is the default one, as that's called by SPI. The other one will only ever be called by the default one, hence we can merge the two into one and simplify things a bit.
javanna
added
>refactoring
:Search Foundations/Search
elasticsearchmachine
added
the
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
javanna
added
the
auto-backport
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 5, 2025
The only public constructor needed in the archive index codecs is the default one, as that's called by SPI. The other one will only ever be called by the default one, hence we can merge the two into one and simplify things a bit.
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
The only public constructor needed in the archive index codecs is the default one, as that's called by SPI. The other one will only ever be called by the default one, hence we can merge the two into one and simplify things a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only public constructor needed in the archive index codecs is the default one, as that's called by SPI. The other one will only ever be called by the default one, hence we can merge the two into one and simplify things a bit.