Upgrade to latest GCS SDK #124062
Merged
Upgrade to latest GCS SDK #124062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktindall
commented
Mar 5, 2025
| identification within third-party archives. | ||
|
|
||
| Copyright 1999-2005 The Apache Software Foundation | ||
| Copyright [yyyy] [name of copyright owner] |
There was a problem hiding this comment.
This is really the LICENSE: https://github.com/open-telemetry/opentelemetry-java/blob/main/LICENSE
nicktindall
commented
Mar 17, 2025
| exchange.getResponseHeaders().add("Range", updateResponse.rangeHeader().headerString()); | ||
| } | ||
| exchange.getResponseHeaders().add("Content-Length", "0"); | ||
| exchange.getResponseHeaders().add("x-goog-stored-content-length", String.valueOf(updateResponse.storedContentLength())); |
There was a problem hiding this comment.
The new client is stricter about receiving a content-length
nicktindall
commented
Mar 17, 2025
...est/java/org/elasticsearch/repositories/gcs/GoogleCloudStorageBlobContainerRetriesTests.java
Outdated
Show resolved
Hide resolved
elasticsearchmachine
added
the
needs:triage
nicktindall
added
>feature
:Distributed Coordination/Snapshot/Restore
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
|
Hi @nicktindall, I've created a changelog YAML for you. |
nicktindall
added
>upgrade
and removed
>feature
Team:Distributed Coordination
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Hi @nicktindall, I've updated the changelog YAML for you. |
nicktindall
commented
Mar 25, 2025
| throw storageException; | ||
| } | ||
| throw e; | ||
| } |
There was a problem hiding this comment.
The alternative to this is something like
catch (IOException | StorageException e) {
StorageException se = (StorageException) ExceptionHelper.unwrap(e, StorageException.class);
if (se != null) {
// do StorageException-specific things
}
}in both catch blocks
nicktindall
commented
Mar 25, 2025
| // Also retry on `SocketException`s | ||
| if (ExceptionsHelper.unwrap(prevThrowable, SocketException.class) != null) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Something has changed at the HTTP call sites and we now get BaseStorageExceptions propagate with cause SocketException and retryable=false. The legacy retry strategy relies on retryable flag so we need to manually intervene here.
I think this is a sign we should be making moves towards DefaultStorageRetryStrategy as I think it would be handled correctly there.
Actually that's worse.
nicktindall
added a commit
to nicktindall/elasticsearch
that referenced
this pull request
Mar 27, 2025
This reverts commit 073ca0e.
nicktindall
added a commit
to nicktindall/elasticsearch
that referenced
this pull request
Mar 28, 2025
This reverts commit 073ca0e.
nicktindall
added a commit
to nicktindall/elasticsearch
that referenced
this pull request
Mar 28, 2025
This reverts commit 073ca0e.
nicktindall
added a commit
to nicktindall/elasticsearch
that referenced
this pull request
Mar 28, 2025
This reverts commit 073ca0e.
nicktindall
added a commit
that referenced
this pull request
Mar 28, 2025
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Upgrades google cloud SDK used by repository-gcp to com.google.cloud:google-cloud-storage-bom:2.50.0 Closes: ES-9287
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
This reverts commit 073ca0e.
nicktindall
added a commit
to nicktindall/elasticsearch
that referenced
this pull request
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded to
com.google.cloud:google-cloud-storage-bom:2.50.0This is the first release that includes the fix for googleapis/java-storage#2972, which breaks our build because of the randomised locale.