[Gradle] Autoprovision jvm for gradle daemon #124071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
breskeby
commented
Mar 5, 2025
| ) | ||
| ] | ||
| toolchainPlatforms.set(myPlatforms) | ||
| languageVersion = JavaLanguageVersion.of(21) |
There was a problem hiding this comment.
@jozala brought up that those archived oracle jdks are not openjdk anymore and we might hit a license issue here. I wonder if we are okay here or if we should maybe use a different openjdk vendor. @mark-vieira do you have thoughts on this?. IMO since this is build vm only. the safest way might be using adoptium
There was a problem hiding this comment.
I forget the exact license terms. We aren't "redistributing" so we're probably ok, but I guess it would be considered "commercial use". If there are any concerns I agree that just using Adoptium would be easiest. We're not picky here, since this is only used by build-time toolchains.
There was a problem hiding this comment.
lets go with the Adoptium jvm then for the gradle jvm
mark-vieira
reviewed
Mar 5, 2025
| @@ -0,0 +1,8 @@ | |||
| #This file is generated by updateDaemonJvm | |||
There was a problem hiding this comment.
Ah I see. It doesn't actually do dynamic resolution. This is still way better than the status quo though of people running into random issues when using new JDKs. And this rarely will need to be updated.
breskeby
force-pushed
the
autoprovision-gradle-daemon
branch
from
40063da to
64b64b0
Compare
This was referenced Mar 18, 2025
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Mar 18, 2025
With Gradle 8.13 we can now auto provision the jdk used by the gradle daemon. Our configuration relies on jdk21. With this autoprovisioning enabled each gradle build will use adoptium jdk 21 for gradle jvm
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Mar 18, 2025
With Gradle 8.13 we can now auto provision the jdk used by the gradle daemon. Our configuration relies on jdk21. With this autoprovisioning enabled each gradle build will use adoptium jdk 21 for gradle jvm
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Mar 18, 2025
With Gradle 8.13 we can now auto provision the jdk used by the gradle daemon. Our configuration relies on jdk21. With this autoprovisioning enabled each gradle build will use adoptium jdk 21 for gradle jvm
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Mar 18, 2025
With Gradle 8.13 we can now auto provision the jdk used by the gradle daemon. Our configuration relies on jdk21. With this autoprovisioning enabled each gradle build will use adoptium jdk 21 for gradle jvm
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Mar 18, 2025
With Gradle 8.13 we can now auto provision the jdk used by the gradle daemon. Our configuration relies on jdk21. With this autoprovisioning enabled each gradle build will use adoptium jdk 21 for gradle jvm
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 18, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 18, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 19, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 19, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 21, 2025
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Mar 21, 2025
With Gradle 8.13 we can now auto provision the jdk used by the gradle daemon. Our configuration relies on jdk21. With this autoprovisioning enabled each gradle build will use adoptium jdk 21 for gradle jvm
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
With Gradle 8.13 we can now auto provision the jdk used by the gradle daemon. Our configuration relies on jdk21. With this autoprovisioning enabled each gradle build will use adoptium jdk 21 for gradle jvm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.