Skip to content

Use regexes to match monitoring tests with messages that change in v9 #124080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thecoop merged 2 commits into from
Mar 5, 2025
Merged

Use regexes to match monitoring tests with messages that change in v9 #124080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6239b2
Use regexes to match monitoring tests with messages that change in v9
thecoop Mar 5, 2025
305e466
Fix escaping
thecoop Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/monitoring/bulk/10_basic.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
---
"Bulk indexing of monitoring data":
- skip:
features: ["allowed_warnings"]
features: ["allowed_warnings_regex"]

- do:
allowed_warnings:
- "[xpack.monitoring.collection.enabled] setting was deprecated in Elasticsearch and will be removed in a future release."
allowed_warnings_regex:
- "\\[xpack.monitoring.collection.enabled] setting was deprecated in Elasticsearch and will be removed in a future release.*"
cluster.put_settings:
body:
persistent:
Expand Down Expand Up @@ -172,11 +172,11 @@
---
"Bulk indexing of monitoring data on closed indices should throw an export exception":
- skip:
features: ["allowed_warnings"]
features: ["allowed_warnings", "allowed_warnings_regex"]

- do:
allowed_warnings:
- "[xpack.monitoring.collection.enabled] setting was deprecated in Elasticsearch and will be removed in a future release."
allowed_warnings_regex:
- "\\[xpack.monitoring.collection.enabled] setting was deprecated in Elasticsearch and will be removed in a future release.*"
cluster.put_settings:
body:
persistent:
Expand Down
6 changes: 3 additions & 3 deletions ...ck/plugin/src/yamlRestTest/resources/rest-api-spec/test/monitoring/bulk/20_privileges.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,11 @@ teardown:
---
"Monitoring Bulk API":
- skip:
features: ["catch_unauthorized", "allowed_warnings"]
features: ["catch_unauthorized", "allowed_warnings_regex"]

- do:
allowed_warnings:
- "[xpack.monitoring.collection.enabled] setting was deprecated in Elasticsearch and will be removed in a future release."
allowed_warnings_regex:
- "\\[xpack.monitoring.collection.enabled] setting was deprecated in Elasticsearch and will be removed in a future release.*"
cluster.put_settings:
body:
persistent:
Expand Down