Add .monitoring exemption to DotPrefixValidator
#124158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was something we were planning on removing, but have not yet. Resolves elastic#124131
dakrone
added
>non-issue
:Data Management/Indices APIs
elasticsearchmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
consulthys
reviewed
Mar 6, 2025
| "\\.slo-observability\\.summary-v\\d+.*", | ||
| "\\.entities\\.v\\d+\\.latest\\..*" | ||
| "\\.entities\\.v\\d+\\.latest\\..*", | ||
| "\\.monitoring-es-8-.*" |
Contributor
There was a problem hiding this comment.
I would probably add an exception for .monitoring-.*, as es is just one of them. Metricbeat can send data to 3 more data streams, namely:
.monitoring-logstash-8-mb.monitoring-kibana-8-mb.monitoring-beats-8-mb
And potentially, Metricbeat 8 could send monitoring data from an old Enterprise Search 8 on ES 9 into .monitoring-ent-search-8-mb
Member
Author
There was a problem hiding this comment.
Okay, I've added exemptions for these patterns as well. I'm avoiding the .monitoring-.* pattern to try and avoid potential abuse or missing user-created data.
dakrone
added
auto-merge-without-approval
Collaborator
💚 Backport successful
|
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Mar 11, 2025
This was something we were planning on removing, but have not yet. Resolves elastic#124131
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 12, 2025
This was something we were planning on removing, but have not yet. Resolves #124131
albertzaharovits
pushed a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Mar 13, 2025
This was something we were planning on removing, but have not yet. Resolves elastic#124131
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Mar 13, 2025
This was something we were planning on removing, but have not yet. Resolves elastic#124131
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was something we were planning on removing, but have not yet.
Resolves #124131