Refactor RegisteredDomainProcessorTests #124175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of this test is to show the various outcomes that cover different fields being set or not set.
joegallo
added
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
This was referenced Mar 6, 2025
Collaborator
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Mar 6, 2025
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Mar 6, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 6, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 6, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 6, 2025
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
costin
pushed a commit
to costin/elasticsearch
that referenced
this pull request
Mar 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #124118 and #124123
The latter PR exposed some methods for testing purposes, but this PR actually takes advantage of that -- I wanted it to be more obvious that the rewriting of the tests didn't change the behavior of the tests (hence the separate PRs).
Technically there is a change to the source as well, don't miss that.