Add tests for non-fatal errors in data node request sender #124203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
>non-issue
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
dnhatn
approved these changes
Mar 6, 2025
Member
dnhatn
left a comment
dnhatn
left a comment
There was a problem hiding this comment.
LGTM. Can we backport this to 8.x too? Thanks @idegtiarenko
| record TargetShard(ShardId shardId, List<DiscoveryNode> remainingNodes, AliasFilter aliasFilter) { | ||
|
|
||
| } | ||
| record TargetShard(ShardId shardId, List<DiscoveryNode> remainingNodes, AliasFilter aliasFilter) {} |
Member
There was a problem hiding this comment.
Why did you make these changes in this class?
Contributor
Author
There was a problem hiding this comment.
I think that was automatically reformatted
idegtiarenko
added
auto-backport
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Contributor
Author
|
Aha, it looks like |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 7, 2025
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds test cases for non fatal errors