Make AbstractSearchAsyncAction release resources earlier #124275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can release resources earlier by releasing before responding to the listener (everything that needs retaining is retained via the search response already) as well as make the GCs life a little easier and get obvious correctness by using the listener that nulls out resources in a thread-safe manner intead of a non-thread-safe and mutable list shared across all kinds of places in the code.
original-brownbear
added
>non-issue
:Search Foundations/Search
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
elasticsearchmachine
added
the
Team:Search Foundations
drempapis
reviewed
Mar 13, 2025
| if (doneFuture.isDone()) { | ||
| releasable.close(); | ||
| } else { | ||
| doneFuture.addListener(ActionListener.releasing((releasable))); |
Contributor
There was a problem hiding this comment.
Minor: There is a pair of extra parenthesis around releasable.
drempapis
reviewed
Mar 13, 2025
| */ | ||
| public void addReleasable(Releasable releasable) { | ||
| releasables.add(releasable); | ||
| var doneFuture = this.doneFuture; |
Contributor
There was a problem hiding this comment.
Should a check be added here to verify that the releasable is not null?
Contributor
Author
There was a problem hiding this comment.
No need to at this point I think, all the spots we're using this for are null safe. And we really shouldn't be adding more uses of this I think :) It's quite imprecise, many of the things we add here could probably be released earlier in their lifecycle. => no new nulls incoming either 🤞
drempapis
approved these changes
Mar 13, 2025
Contributor
drempapis
left a comment
drempapis
left a comment
There was a problem hiding this comment.
LGTM, thanks for sharing this
Contributor
Author
|
Thanks Dimitris! |
original-brownbear
added
the
auto-backport
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 13, 2025
…124800) We can release resources earlier by releasing before responding to the listener (everything that needs retaining is retained via the search response already) as well as make the GCs life a little easier and get obvious correctness by using the listener that nulls out resources in a thread-safe manner intead of a non-thread-safe and mutable list shared across all kinds of places in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can release resources earlier by releasing before responding to the listener (everything that needs retaining is retained via the search response already) as well as make the GCs life a little easier and get obvious correctness by using the listener that nulls out resources in a thread-safe manner instead of a non-thread-safe and mutable list shared across all kinds of places in the code (currently this pretty much just works out by accident because we only add resources when moving to new phases).
This also fixes a potential bug around adding a releasable resource after the listener has already failed.