-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[Test] Move helper mthods for multi-project rest test #124285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
elasticsearchmachine
merged 4 commits into
elastic:main
from
ywangd:mp/move-helper-methods-to-es-rest-test-case
Mar 11, 2025
Merged
[Test] Move helper mthods for multi-project rest test #124285
elasticsearchmachine
merged 4 commits into
elastic:main
from
ywangd:mp/move-helper-methods-to-es-rest-test-case
Mar 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR moves the helper methods up to the base ESRestTestCase class so that they can be reused by other subclasses, e.g. the ones on the serverless side.
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
nielsbauman
approved these changes
Mar 7, 2025
Contributor
nielsbauman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense. If other people have different opinions, we can always move them back/somewhere else.
Member
Author
|
@elasticmachine update branch |
albertzaharovits
pushed a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Mar 13, 2025
This PR moves the helper methods up to the base ESRestTestCase class so that they can be reused by other subclasses, e.g. the ones on the serverless side. Relates: ES-10292
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Mar 13, 2025
This PR moves the helper methods up to the base ESRestTestCase class so that they can be reused by other subclasses, e.g. the ones on the serverless side. Relates: ES-10292
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Core/Infra/Core
Core issues without another label
serverless-linked
Added by automation, don't add manually
Team:Core/Infra
Meta label for core/infra team
>test
Issues or PRs that are addressing/adding tests
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the helper methods up to the base ESRestTestCase class so that they can be reused by other subclasses, e.g. the ones on the serverless side.
Relates: ES-10292