Skip to content

Conversation

@ywangd
Copy link
Member

@ywangd ywangd commented Mar 7, 2025

This PR moves the helper methods up to the base ESRestTestCase class so that they can be reused by other subclasses, e.g. the ones on the serverless side.

Relates: ES-10292

This PR moves the helper methods up to the base ESRestTestCase class so
that they can be reused by other subclasses, e.g. the ones on the
serverless side.
@ywangd ywangd added >non-issue >test Issues or PRs that are addressing/adding tests :Core/Infra/Core Core issues without another label labels Mar 7, 2025
@ywangd ywangd requested a review from tvernum March 7, 2025 02:30
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added v9.1.0 Team:Core/Infra Meta label for core/infra team labels Mar 7, 2025
@ywangd ywangd removed the >non-issue label Mar 7, 2025
@ywangd ywangd requested a review from a team March 7, 2025 03:26
@elasticsearchmachine elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Mar 7, 2025
Copy link
Contributor

@nielsbauman nielsbauman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. If other people have different opinions, we can always move them back/somewhere else.

@ywangd
Copy link
Member Author

ywangd commented Mar 10, 2025

@elasticmachine update branch

@ywangd ywangd added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Mar 10, 2025
@elasticsearchmachine elasticsearchmachine merged commit 207c2df into elastic:main Mar 11, 2025
17 checks passed
@ywangd ywangd deleted the mp/move-helper-methods-to-es-rest-test-case branch March 11, 2025 01:53
albertzaharovits pushed a commit to albertzaharovits/elasticsearch that referenced this pull request Mar 13, 2025
This PR moves the helper methods up to the base ESRestTestCase class so
that they can be reused by other subclasses, e.g. the ones on the
serverless side.

Relates: ES-10292
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Mar 13, 2025
This PR moves the helper methods up to the base ESRestTestCase class so
that they can be reused by other subclasses, e.g. the ones on the
serverless side.

Relates: ES-10292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Core Core issues without another label serverless-linked Added by automation, don't add manually Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants