ESQL: Unmute and fix BlockMultiValuedTests.testToMask #124339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivancea
added
>test
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
ivancea
commented
Mar 7, 2025
| return; | ||
| } | ||
| int positionCount = randomIntBetween(1, 16 * 1024); | ||
| int positionCount = randomIntBetween(0, 16 * 1024); |
Contributor
Author
There was a problem hiding this comment.
This change doesn't do much, but as it now correctly works with 0 elements, we assert that noElements == !hadMultivaluedFields
idegtiarenko
approved these changes
Mar 10, 2025
Contributor
Author
|
Just checked the other tests in this class; they have the required checks in place |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124165