DateProcessor refactoring #124349
Merged
DateProcessor refactoring #124349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
added
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Locale.ROOT doesn't round trip -- it results in a langugage tag of "und" (undefined, I suppose), and when you round-trip back you don't get Locale.ROOT from it. The old test worked because it was fundamentally just testing that the template script execution would result in the expected string (whether or not you could actually do anything with the Locale that would result), while this new test is checking the round-trip behavior.
joegallo
force-pushed
the
date-processor-refactoring
branch
from
37783ee to
6305025
Compare
masseyke
approved these changes
Mar 7, 2025
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Mar 8, 2025
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Mar 8, 2025
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Mar 8, 2025
This was referenced Mar 8, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 8, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 8, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 8, 2025
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a refactoring PR, it cleans up some code and encapsulates the template application logic to the internals of the
DateProcessorrather than exposing it quite as directly. There's a performance improvement coming that builds on this, but this ain't it.For the record, though, I do think this version of the logic is easier to follow.