Fix test - wait for other threads before throwing the exception #124386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalyshev
added
>test
elasticsearchmachine
added
the
Team:Search Foundations
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
smalyshev
added
the
auto-backport
original-brownbear
approved these changes
Mar 7, 2025
Contributor
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
Looks good, what do you think about my suggestion though to simplify this slightly? :)
|
|
||
| // When the search request executes, block all shards except 1. | ||
| final List<SearchShardBlockingPlugin> searchShardBlockingPlugins = initSearchShardBlockingPlugin(); | ||
| AtomicBoolean letOneShardProceed = new AtomicBoolean(); |
Contributor
There was a problem hiding this comment.
Maybe we could make this slightly simpler by using a nAtomicReference<CountDownLatch> and then doing something like latch = getAndSet(null); if (latch != null) latch.await to save a variable?
Contributor
Author
There was a problem hiding this comment.
Not sure I understood how it should work. I think it's better to check if this one works and then if it fixes the issues then we can refactor it.
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Mar 8, 2025
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Mar 8, 2025
…tic#124386) (cherry picked from commit b9a9784) # Conflicts: # server/src/internalClusterTest/java/org/elasticsearch/search/SearchCancellationIT.java
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Mar 8, 2025
…tic#124386) (cherry picked from commit b9a9784) # Conflicts: # server/src/internalClusterTest/java/org/elasticsearch/search/SearchCancellationIT.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 8, 2025
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121719