Skip to content

[Entitlements] Fix File tests to work across multiple invocations #124412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

[Entitlements] Fix File tests to work across multiple invocations #124412

merged 1 commit into from
Mar 10, 2025

Conversation

@ldematte
Copy link
Contributor

@ldematte ldematte commented Mar 8, 2025

Some File tests use fixed file names, that can clash if the same tests is invoked multiple times (e.g. with the -Dtests.iters=N flag).
This PR fixes that by using temp paths with unique (random) names

@ldematte ldematte added >test Issues or PRs that are addressing/adding tests auto-backport Automatically create backport pull requests when merged v8.18.1 v8.19.0 v9.0.1 v9.1.0 :Core/Infra/Entitlements Entitlements infrastructure labels Mar 8, 2025
@ldematte ldematte requested a review from a team as a code owner March 8, 2025 15:02
prdoyle
prdoyle approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@prdoyle prdoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@ldematte ldematte merged commit a2b0d96 into elastic:main Mar 10, 2025
16 checks passed
ldematte added a commit to ldematte/elasticsearch that referenced this pull request Mar 10, 2025
@ldematte
fix file tests to work across multiple invocations (elastic#124412)
1841567
This was referenced Mar 10, 2025
Merged
Merged
Merged
ldematte added a commit to ldematte/elasticsearch that referenced this pull request Mar 10, 2025
@ldematte
fix file tests to work across multiple invocations (elastic#124412)
4a566d9
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 10, 2025

💚 Backport successful

Status Branch Result
✅ 8.18
✅ 8.x
✅ 9.0

ldematte added a commit to ldematte/elasticsearch that referenced this pull request Mar 10, 2025
@ldematte
fix file tests to work across multiple invocations (elastic#124412)
0f56ab6
elasticsearchmachine pushed a commit that referenced this pull request Mar 10, 2025
@ldematte
fix file tests to work across multiple invocations (#124412) (#124505)
033f974
elasticsearchmachine pushed a commit that referenced this pull request Mar 10, 2025
@ldematte
fix file tests to work across multiple invocations (#124412) (#124503)
b23b5b0
elasticsearchmachine pushed a commit that referenced this pull request Mar 10, 2025
@ldematte
fix file tests to work across multiple invocations (#124412) (#124504)
5ead06f
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Mar 11, 2025
@ldematte @georgewallace
fix file tests to work across multiple invocations (elastic#124412)
a93865c
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Mar 13, 2025
@ldematte @jfreden
fix file tests to work across multiple invocations (elastic#124412)
fdf577a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prdoyle prdoyle prdoyle approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged :Core/Infra/Entitlements Entitlements infrastructure >test Issues or PRs that are addressing/adding tests v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ldematte @elasticsearchmachine @prdoyle