Remove some overhead from TransportService message handling #124428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoiding some indirection, volatile-reads and moving the listener functionality that needlessly kept iterating an empty CoW list (creating iterator instances, volatile reads, more code) in an effort to improve the low IPC on transport threads.
original-brownbear
added
>non-issue
:Distributed Coordination/Network
elasticsearchmachine
added
the
Team:Distributed Coordination
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DaveCTurner
approved these changes
Mar 9, 2025
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM makes sense to me. Couple of nits.
| @Override | ||
| protected Collection<Class<? extends Plugin>> nodePlugins() { | ||
| return List.of(AsyncSearch.class); | ||
| return List.of(AsyncSearch.class, MockTransportService.TestPlugin.class); |
Contributor
There was a problem hiding this comment.
I'd prefer we added these things to super.nodePlugins() with appendToCopy or similar. Doesn't really matter in this case right now but adding stuff to ESIntegTestCase#nodePlugins everywhere for an experiment is sometimes handy.
Contributor
Author
There was a problem hiding this comment.
Makes sense :) done :)
| Optional<Throwable> throwable = ExceptionsHelper.unwrapCausesAndSuppressed(error, t -> t.getStackTrace().length > 0); | ||
| transportMessageHasStackTrace.set(throwable.isPresent()); | ||
| internalCluster.getDataNodeInstances(TransportService.class) | ||
| .forEach(ts -> ((MockTransportService) ts).addMessageListener(new TransportMessageListener() { |
Contributor
There was a problem hiding this comment.
Suggest asInstanceOf(MockTransportService.class, ts), we sometimes catch a ClassCastException without failing the test.
original-brownbear
added
the
auto-backport
Contributor
Author
|
Thanks David! |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
…124428) Avoiding some indirection, volatile-reads and moving the listener functionality that needlessly kept iterating an empty CoW list (creating iterator instances, volatile reads, more code) in an effort to improve the low IPC on transport threads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoiding some indirection, volatile-reads and moving the listener functionality that needlessly kept iterating an empty CoW list (creating iterator instances, volatile reads, more code) in an effort to improve the low IPC on transport threads.