[Entitlements] Add support for IT tests of always allowed actions (take 2) #124429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
added
>test
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
prdoyle
approved these changes
Mar 10, 2025
| return entries.stream(); | ||
| } | ||
|
|
||
| private static CheckedConsumer<Environment, Exception> createConsumerForMethod(Method method) { |
There was a problem hiding this comment.
This is pretty neat. Your own tiny DI framework!
| } | ||
| if (parameters.length == 1 && parameters[0].equals(Environment.class)) { | ||
| return env -> method.invoke(null, env); | ||
| } |
There was a problem hiding this comment.
(If we ever acquire a second injectable parameter here, I'd probably change this to loop over the parameters, building the argument list based on the parameter types, much like a real DI framework would.)
There was a problem hiding this comment.
++
But for now all the "extra" info we use is in the environment (e.g. dirs).
But yes, if we need to add more, we can either do that or have "fixed" patterns (either arg-less, or all the additional args in the right order).
There was a problem hiding this comment.
I don't really see the value in forcing the args to be in a certain order. Like, what if I want to inject A and C? Do I need to declare B for no reason just so I have the right args in the right order? Also, why is (A, C) ok but (C, A) is not?
It will not surprise you that I'd prefer just to have DI. 😂
…lways-allowed-actions-2
…lways-allowed-actions-2
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Mar 12, 2025
…ke 2) (elastic#124429) Writing tests for elastic#123861, turns out that elastic#124195 is not enough. We really need new IT test cases for "always allowed" actions: in order to be sure they are allowed, we need to setup the plugin with no policy. This PR adds test cases for that, plus the support for writing test functions that accept one Environment parameter: many test paths we test and allow/deny are relative to paths in Environment, so it's useful to have access to it (see readAccessConfigDirectory as an example)
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 12, 2025
…ke 2) (#124429) (#124627) Writing tests for #123861, turns out that #124195 is not enough. We really need new IT test cases for "always allowed" actions: in order to be sure they are allowed, we need to setup the plugin with no policy. This PR adds test cases for that, plus the support for writing test functions that accept one Environment parameter: many test paths we test and allow/deny are relative to paths in Environment, so it's useful to have access to it (see readAccessConfigDirectory as an example)
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Mar 13, 2025
…ke 2) (elastic#124429) Writing tests for elastic#123861, turns out that elastic#124195 is not enough. We really need new IT test cases for "always allowed" actions: in order to be sure they are allowed, we need to setup the plugin with no policy. This PR adds test cases for that, plus the support for writing test functions that accept one Environment parameter: many test paths we test and allow/deny are relative to paths in Environment, so it's useful to have access to it (see readAccessConfigDirectory as an example)
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Mar 13, 2025
…ke 2) (elastic#124429) Writing tests for elastic#123861, turns out that elastic#124195 is not enough. We really need new IT test cases for "always allowed" actions: in order to be sure they are allowed, we need to setup the plugin with no policy. This PR adds test cases for that, plus the support for writing test functions that accept one Environment parameter: many test paths we test and allow/deny are relative to paths in Environment, so it's useful to have access to it (see readAccessConfigDirectory as an example)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 13, 2025
…ke 2) (#124429) (#124703) Writing tests for #123861, turns out that #124195 is not enough. We really need new IT test cases for "always allowed" actions: in order to be sure they are allowed, we need to setup the plugin with no policy. This PR adds test cases for that, plus the support for writing test functions that accept one Environment parameter: many test paths we test and allow/deny are relative to paths in Environment, so it's useful to have access to it (see readAccessConfigDirectory as an example)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 13, 2025
…ke 2) (#124429) (#124704) Writing tests for #123861, turns out that #124195 is not enough. We really need new IT test cases for "always allowed" actions: in order to be sure they are allowed, we need to setup the plugin with no policy. This PR adds test cases for that, plus the support for writing test functions that accept one Environment parameter: many test paths we test and allow/deny are relative to paths in Environment, so it's useful to have access to it (see readAccessConfigDirectory as an example)
albertzaharovits
pushed a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Mar 13, 2025
…ke 2) (elastic#124429) Writing tests for elastic#123861, turns out that elastic#124195 is not enough. We really need new IT test cases for "always allowed" actions: in order to be sure they are allowed, we need to setup the plugin with no policy. This PR adds test cases for that, plus the support for writing test functions that accept one Environment parameter: many test paths we test and allow/deny are relative to paths in Environment, so it's useful to have access to it (see readAccessConfigDirectory as an example)
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Mar 13, 2025
…ke 2) (elastic#124429) Writing tests for elastic#123861, turns out that elastic#124195 is not enough. We really need new IT test cases for "always allowed" actions: in order to be sure they are allowed, we need to setup the plugin with no policy. This PR adds test cases for that, plus the support for writing test functions that accept one Environment parameter: many test paths we test and allow/deny are relative to paths in Environment, so it's useful to have access to it (see readAccessConfigDirectory as an example)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing tests for #123861, turns out that #124195 is not enough.
We really need new IT test cases for "always allowed" actions: in order to be sure they are allowed, we need to setup the plugin with no policy.
This PR adds test cases for that, plus the support for writing test functions that accept one Environment parameter: many test paths we test and allow/deny are relative to paths in Environment, so it's useful to have access to it (see
readAccessConfigDirectoryas an example)