Ignore ordering in policy manager exclulsive tests #124488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjernst
added
>test
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
prdoyle
approved these changes
Mar 10, 2025
Contributor
prdoyle
left a comment
prdoyle
left a comment
There was a problem hiding this comment.
I don't know the motivation, but this change seems uncontroversial, and I can confirm it doesn't change what's being tested.
Member
Author
The original using Map.of created a hashmap which had inconsistent ordering, which then can fail the exclusive test because the order of the exception message (the two components/modules that want to have exclusive access). |
rjernst
changed the title
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.