Skip to content

Improve DownsampleActionSingleNodeTests testing #124550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2025
Merged

Improve DownsampleActionSingleNodeTests testing #124550

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c474a3f
Improve DownsampleActionSingleNodeTests testing.
martijnvg Mar 11, 2025
3a74381
iter
martijnvg Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 24 additions & 18 deletions ...ple/src/test/java/org/elasticsearch/xpack/downsample/DownsampleActionSingleNodeTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1120,25 +1120,31 @@ private void bulkIndex(SourceSupplier sourceSupplier) throws IOException {
}

private void bulkIndex(final String indexName, final SourceSupplier sourceSupplier, int docCount) throws IOException {
BulkRequestBuilder bulkRequestBuilder = client().prepareBulk();
bulkRequestBuilder.setRefreshPolicy(WriteRequest.RefreshPolicy.IMMEDIATE);
for (int i = 0; i < docCount; i++) {
IndexRequest indexRequest = new IndexRequest(indexName).opType(DocWriteRequest.OpType.CREATE);
XContentBuilder source = sourceSupplier.get();
indexRequest.source(source);
bulkRequestBuilder.add(indexRequest);
}
BulkResponse bulkResponse = bulkRequestBuilder.get();
// Index in such a way that we always have multiple segments, so that we test DownsampleShardIndexer in a more realistic scenario:
// (also makes failures more reproducible)
int duplicates = 0;
for (BulkItemResponse response : bulkResponse.getItems()) {
if (response.isFailed()) {
if (response.getFailure().getCause() instanceof VersionConflictEngineException) {
// A duplicate event was created by random generator. We should not fail for this
// reason.
logger.debug("We tried to insert a duplicate: [{}]", response.getFailureMessage());
duplicates++;
} else {
fail("Failed to index data: " + bulkResponse.buildFailureMessage());
for (int i = 0; i < docCount;) {
BulkRequestBuilder bulkRequestBuilder = client().prepareBulk();
bulkRequestBuilder.setRefreshPolicy(WriteRequest.RefreshPolicy.IMMEDIATE);
int max = Math.min(i + 100, docCount);
for (int j = i; j < max; j++) {
IndexRequest indexRequest = new IndexRequest(indexName).opType(DocWriteRequest.OpType.CREATE);
XContentBuilder source = sourceSupplier.get();
indexRequest.source(source);
bulkRequestBuilder.add(indexRequest);
}
i = max;
BulkResponse bulkResponse = bulkRequestBuilder.get();
for (BulkItemResponse response : bulkResponse.getItems()) {
if (response.isFailed()) {
if (response.getFailure().getCause() instanceof VersionConflictEngineException) {
// A duplicate event was created by random generator. We should not fail for this
// reason.
logger.debug("We tried to insert a duplicate: [{}]", response.getFailureMessage());
duplicates++;
} else {
fail("Failed to index data: " + bulkResponse.buildFailureMessage());
}
}
}
}
Expand Down