Filter module-info.class from entitlements-bridge jar in distribution #124580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
:Delivery/Build
elasticsearchmachine
added
Team:Core/Infra
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
rjernst
approved these changes
Mar 11, 2025
| // Register artifact transform for filtering entitlements-bridge jar | ||
| FilteringJarTransform.registerTransform(dependencies) { spec -> | ||
| spec.exclude('module-info.class') | ||
| spec.exclude('META-INF/versions/**') |
Member
There was a problem hiding this comment.
If you also add a second line for spec.exclude('META-INF/versions') will that remove the directory too?
Contributor
Author
There was a problem hiding this comment.
Nope. I tried. It seems PathMatcher doesn't handle directories that way.
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Mar 11, 2025
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Mar 11, 2025
…elastic#124580) (cherry picked from commit 74ccd4d) # Conflicts: # distribution/build.gradle
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Mar 11, 2025
…elastic#124580) (cherry picked from commit 74ccd4d) # Conflicts: # distribution/build.gradle
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 11, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 11, 2025
mark-vieira
added a commit
that referenced
this pull request
Mar 12, 2025
albertzaharovits
pushed a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Mar 13, 2025
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entitlement bridge jar is patched into java.base at runtime. At build time it is modular, so it contains a module-info.java. Yet at runtime this produces a warning from the jdk because the module info is ignored. We should remove the module info from the jar we put in the distribution to avoid the warning.
This is implemented as a Gradle artifact transform for a few reasons:
Jartasks on the producer side which have to be kept in sync.