[ES|QL] ToAggregateMetricDouble function #124595
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,9 +7,17 @@ | |
|
|
||
| package org.elasticsearch.compute.data; | ||
|
|
||
| import org.elasticsearch.TransportVersion; | ||
| import org.elasticsearch.TransportVersions; | ||
| import org.elasticsearch.common.io.stream.GenericNamedWriteable; | ||
| import org.elasticsearch.common.io.stream.NamedWriteableRegistry; | ||
| import org.elasticsearch.common.io.stream.StreamInput; | ||
| import org.elasticsearch.common.io.stream.StreamOutput; | ||
| import org.elasticsearch.core.Releasables; | ||
| import org.elasticsearch.index.mapper.BlockLoader; | ||
|
|
||
| import java.io.IOException; | ||
|
|
||
| public class AggregateMetricDoubleBlockBuilder extends AbstractBlockBuilder implements BlockLoader.AggregateMetricDoubleBuilder { | ||
|
|
||
| private DoubleBlockBuilder minBuilder; | ||
|
|
@@ -161,11 +169,107 @@ public String getLabel() { | |
| } | ||
| } | ||
|
|
||
| public record AggregateMetricDoubleLiteral(Double min, Double max, Double sum, Integer count) implements GenericNamedWriteable { | ||
| public AggregateMetricDoubleLiteral { | ||
| min = min.isNaN() ? null : min; | ||
| max = max.isNaN() ? null : max; | ||
| sum = sum.isNaN() ? null : sum; | ||
| } | ||
|
|
||
| public static final NamedWriteableRegistry.Entry ENTRY = new NamedWriteableRegistry.Entry( | ||
| GenericNamedWriteable.class, | ||
| "AggregateMetricDoubleLiteral", | ||
| AggregateMetricDoubleLiteral::new | ||
| ); | ||
|
|
||
| @Override | ||
| public String getWriteableName() { | ||
| return "AggregateMetricDoubleLiteral"; | ||
| } | ||
|
|
||
| public AggregateMetricDoubleLiteral(StreamInput input) throws IOException { | ||
| this(input.readOptionalDouble(), input.readOptionalDouble(), input.readOptionalDouble(), input.readOptionalInt()); | ||
| } | ||
|
|
||
| @Override | ||
| public void writeTo(StreamOutput out) throws IOException { | ||
| out.writeOptionalDouble(min); | ||
| out.writeOptionalDouble(max); | ||
| out.writeOptionalDouble(sum); | ||
| out.writeOptionalInt(count); | ||
| } | ||
|
|
||
| @Override | ||
| public TransportVersion getMinimalSupportedVersion() { | ||
| return TransportVersions.ESQL_AGGREGATE_METRIC_DOUBLE_LITERAL; | ||
| } | ||
|
|
||
| } | ||
|
|
||
| public static class AggregateMetricDoubleVectorBuilder extends AbstractBlockBuilder { | ||
| private final DoubleBlockBuilder valuesBuilder; | ||
|
|
||
| public AggregateMetricDoubleVectorBuilder(int estimatedSize, BlockFactory blockFactory) { | ||
| super(blockFactory); | ||
| valuesBuilder = new DoubleBlockBuilder(estimatedSize, blockFactory); | ||
limotova marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| @Override | ||
| protected int valuesLength() { | ||
|
||
| throw new UnsupportedOperationException("Not available on aggregate_metric_double"); | ||
| } | ||
|
|
||
| @Override | ||
| protected void growValuesArray(int newSize) { | ||
| throw new UnsupportedOperationException("Not available on aggregate_metric_double"); | ||
| } | ||
|
|
||
| @Override | ||
| protected int elementSize() { | ||
| throw new UnsupportedOperationException("Not available on aggregate_metric_double"); | ||
| } | ||
|
|
||
| @Override | ||
| public Block.Builder copyFrom(Block block, int beginInclusive, int endExclusive) { | ||
| // TODO | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public Block.Builder mvOrdering(Block.MvOrdering mvOrdering) { | ||
| // TODO | ||
| return null; | ||
| } | ||
|
|
||
| public void appendValue(double value) { | ||
| valuesBuilder.appendDouble(value); | ||
| } | ||
|
|
||
| @Override | ||
| public Block build() { | ||
| Block[] blocks = new Block[4]; | ||
| Block block = null; | ||
| IntBlock countVector = null; | ||
| boolean success = false; | ||
| try { | ||
| finish(); | ||
| block = valuesBuilder.build(); | ||
| countVector = blockFactory.newConstantIntBlockWith(1, block.getPositionCount()); | ||
| blocks[Metric.MIN.getIndex()] = block; | ||
| blocks[Metric.MAX.getIndex()] = block; | ||
| block.incRef(); | ||
| blocks[Metric.SUM.getIndex()] = block; | ||
| block.incRef(); | ||
| blocks[Metric.COUNT.getIndex()] = countVector; | ||
| CompositeBlock compositeBlock = new CompositeBlock(blocks); | ||
| success = true; | ||
| return compositeBlock; | ||
| } finally { | ||
| if (success == false) { | ||
| Releasables.closeExpectNoException(blocks); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not extend from BlockBuilder but just a Releasable here. Also should we move this to ToAggregateMetricDouble class instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think keeping it in ToAggregateMetricDouble makes sense, I moved it there, but that class is getting quite heavy, I wonder if the factories should be moved into a separate file?