Skip to content

[9.0] [Profiling] Fix NullPointerExceptions by accepting dotted field names (#124506) #124621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

[9.0] [Profiling] Fix NullPointerExceptions by accepting dotted field names (#124506) #124621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...k/plugin/profiling/src/main/java/org/elasticsearch/xpack/profiling/action/StackTrace.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,15 @@ static String getFileIDFromStackFrameID(String frameID) {

public static StackTrace fromSource(Map<String, Object> source) {
String inputFrameIDs = ObjectPath.eval(PATH_FRAME_IDS, source);
if (inputFrameIDs == null) {
// If synthetic source is disabled, fallback to dotted field names.
inputFrameIDs = (String) source.get("Stacktrace.frame.ids");
}
String inputFrameTypes = ObjectPath.eval(PATH_FRAME_TYPES, source);
if (inputFrameTypes == null) {
// If synthetic source is disabled, fallback to dotted field names.
inputFrameTypes = (String) source.get("Stacktrace.frame.types");
}
int countsFrameIDs = inputFrameIDs.length() / BASE64_FRAME_ID_LENGTH;

String[] fileIDs = new String[countsFrameIDs];
Expand Down
7 changes: 6 additions & 1 deletion ...src/main/java/org/elasticsearch/xpack/profiling/action/TransportGetStackTracesAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,7 +788,12 @@ public void onExecutableDetailsResponse(MultiGetResponse multiGetItemResponses)
if (executable.getResponse().isExists()) {
// Duplicates are expected as we query multiple indices - do a quick pre-check before we deserialize a response
if (executables.containsKey(executable.getId()) == false) {
String fileName = ObjectPath.eval(PATH_FILE_NAME, executable.getResponse().getSource());
Map<String, Object> source = executable.getResponse().getSource();
String fileName = ObjectPath.eval(PATH_FILE_NAME, source);
if (fileName == null) {
// If synthetic source is disabled, read from dotted field names.
fileName = (String) source.get("Executable.file.name");
}
if (fileName != null) {
executables.putIfAbsent(executable.getId(), fileName);
} else {
Expand Down