Skip to content

Remove Enterprise Search Service Account #124655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
May 23, 2025
Merged

Remove Enterprise Search Service Account #124655

merged 23 commits into from
May 23, 2025

Conversation

@markjhoy
Copy link
Contributor

@markjhoy markjhoy commented Mar 12, 2025 •
edited
Loading

Enterprise Search will not be in the 9.x version, and as such, we should remove the service account for it. This PR removes the creation of the account and associated tests.

Having this service account here will not break any functionality, but it should be removed regardless.

@markjhoy markjhoy added auto-backport Automatically create backport pull requests when merged v9.0.1 >non-issue Team:Enterprise Search Meta label for Enterprise Search team labels Mar 12, 2025
markjhoy and others added 16 commits March 12, 2025 12:01
@markjhoy
Merge branch 'main' into markjhoy/remove-ent-search-service-account-9x
4bb88c0
@markjhoy
remove all tests referencing ent-search
6e1effd
[CI] Auto commit changes from spotless
95a5cf7
@markjhoy
Merge branch 'main' into markjhoy/remove-ent-search-service-account-9x
03f9314
@markjhoy
ensure yaml tests have correct length
f1d446d
@markjhoy
set proper length expected
dd19be1
@markjhoy
use index for slow log test that works
1fe678c
@markjhoy
skip account REST tests with invalid length
ccd3bf4
@markjhoy
Merge branch 'main' into markjhoy/remove-ent-search-service-account-9x
10d065f
@markjhoy
skip Test service account tokens test too
61878dd
@markjhoy
remove added space
7aae87b
@markjhoy
Merge branch 'main' into markjhoy/remove-ent-search-service-account-9x
89ae55c
@markjhoy
add changelog for PR
2c593fc
@markjhoy
Merge branch 'main' into markjhoy/remove-ent-search-service-account-9x
961b8e9
@markjhoy
update
7062393
@markjhoy
Merge branch 'main' into markjhoy/remove-ent-search-service-account-9x
58b2dc3
@markjhoy markjhoy removed the v9.0.1 label Mar 18, 2025
@markjhoy markjhoy marked this pull request as ready for review March 19, 2025 14:49
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label and removed Team:Enterprise Search Meta label for Enterprise Search team labels Mar 19, 2025
@markjhoy markjhoy requested a review from ioanatia March 19, 2025 14:50
@markjhoy markjhoy added the Team:Enterprise Search Meta label for Enterprise Search team label Mar 19, 2025
@elasticsearchmachine elasticsearchmachine removed the Team:Enterprise Search Meta label for Enterprise Search team label Mar 19, 2025
@markjhoy markjhoy added Team:SearchOrg Meta label for the Search Org (Enterprise Search) and removed needs:triage Requires assignment of a team area label auto-backport Automatically create backport pull requests when merged labels Mar 19, 2025
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label and removed Team:SearchOrg Meta label for the Search Org (Enterprise Search) labels Mar 19, 2025
@markjhoy markjhoy added Team:Security Meta label for security team Team:SearchOrg Meta label for the Search Org (Enterprise Search) labels Mar 20, 2025
@elasticsearchmachine elasticsearchmachine removed Team:Security Meta label for security team Team:SearchOrg Meta label for the Search Org (Enterprise Search) labels Mar 20, 2025
@kderusso kderusso added the :SearchOrg/Relevance Label for the Search (solution/org) Relevance team label Mar 20, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 20, 2025

Pinging @elastic/search-eng (Team:SearchOrg)

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 20, 2025

Pinging @elastic/search-relevance (Team:Search - Relevance)

@kderusso kderusso added the Team:SearchOrg Meta label for the Search Org (Enterprise Search) label Mar 20, 2025
@markjhoy markjhoy requested review from a team March 20, 2025 14:11
kderusso
kderusso approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided CI passes

@PeteGillinElastic PeteGillinElastic removed the needs:triage Requires assignment of a team area label label Mar 21, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Search - Relevance The Search organization Search Relevance team label May 23, 2025
@markjhoy markjhoy merged commit 2310bca into elastic:main May 23, 2025
18 checks passed
@pquentin pquentin mentioned this pull request May 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ioanatia ioanatia ioanatia approved these changes

@kderusso kderusso kderusso approved these changes

Assignees

No one assigned

Labels

>non-issue :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Search - Relevance The Search organization Search Relevance team Team:SearchOrg Meta label for the Search Org (Enterprise Search) v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@markjhoy @elasticsearchmachine @ioanatia @kderusso @PeteGillinElastic