Skip to content

Disable queryable built-in feature in docs YAML tests #124684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 13, 2025
Merged

Disable queryable built-in feature in docs YAML tests #124684

merged 4 commits into from
Mar 13, 2025

Conversation

@slobodanadamovic
Copy link
Contributor

@slobodanadamovic slobodanadamovic commented Mar 12, 2025 •
edited
Loading

The .security index is created asynchronously on a cluster startup. This affects some of the docs YAML tests in a way that they need to account for the existence of the .security index or wait for the index to be created and green. This PR disables the feature for docs YAML tests. Disabling the feature in docs YAML tests will solve the flakiness without affecting the coverage.

Resolves #122343
Resolves #121748
Resolves #121611
Resolves #121345
Resolves #121338
Resolves #121337
Resolves #121288
Resolves #121287
Resolves #121867
Resolves #122335
Resolves #122681
Resolves #121976
Resolves #123094
Resolves #123192
Resolves #122983
Resolves #124671
Resolves #124103

@slobodanadamovic
Disable queryable built-in feature in docs YAML tests
26053a3 
The .security index is created asynchronously on a cluster startup.
This affects some of the docs YAML tests in a way that they need to
account for the existence of the .security index or wait for the index to
be created. This PR disables the feature for docs YAML tests.
Disabling the feature in docs YAML tests will solve the flakiness without
affecting the coverage.
@slobodanadamovic slobodanadamovic added >test Issues or PRs that are addressing/adding tests :Security/Security Security issues without another label Team:Security Meta label for security team auto-backport Automatically create backport pull requests when merged v8.18.1 v8.19.0 v9.0.1 v9.1.0 labels Mar 12, 2025
@slobodanadamovic slobodanadamovic self-assigned this Mar 12, 2025
@slobodanadamovic slobodanadamovic requested a review from a team March 12, 2025 22:11
@slobodanadamovic slobodanadamovic mentioned this pull request Mar 12, 2025
Closed
@slobodanadamovic slobodanadamovic marked this pull request as ready for review March 12, 2025 22:21
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 12, 2025

Pinging @elastic/es-security (Team:Security)

@slobodanadamovic
Merge branch 'main' of github.com:elastic/elasticsearch into sa-disab…
fa33527 
…le-queryable-feature-for-docs

# Conflicts:
#	muted-tests.yml
@slobodanadamovic slobodanadamovic added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Mar 13, 2025
@elasticsearchmachine elasticsearchmachine merged commit cac356a into elastic:main Mar 13, 2025
22 checks passed
@slobodanadamovic slobodanadamovic deleted the sa-disable-queryable-feature-for-docs branch March 13, 2025 12:14
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 13, 2025

💔 Backport failed

Status Branch Result
❌ 8.18 Commit could not be cherrypicked due to conflicts
❌ 8.x Commit could not be cherrypicked due to conflicts
❌ 9.0 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 124684

jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Mar 13, 2025
@slobodanadamovic @jfreden
Disable queryable built-in feature in docs YAML tests (elastic#124684)
15e94ee 
The .security index is created asynchronously on a cluster startup. This
affects some of the docs YAML tests in a way that they need to account
for the existence of the .security index or wait for the index to be
created and green. This PR disables the feature for docs YAML tests.
Disabling the feature in docs YAML tests will solve the flakiness
without affecting the coverage.

Resolves elastic#122343 Resolves
elastic#121748 Resolves
elastic#121611 Resolves
elastic#121345 Resolves
elastic#121338 Resolves
elastic#121337 Resolves
elastic#121288 Resolves
elastic#121287 Resolves
elastic#121867 Resolves
elastic#122335 Resolves
elastic#122681 Resolves
elastic#121976 Resolves
elastic#123094 Resolves
elastic#123192 Resolves
elastic#122983 Resolves
elastic#124671 Resolves
elastic#124103
@slobodanadamovic slobodanadamovic mentioned this pull request Mar 13, 2025
Merged
slobodanadamovic added a commit to slobodanadamovic/elasticsearch that referenced this pull request Mar 13, 2025
@slobodanadamovic
Disable queryable built-in feature in docs YAML tests (elastic#124684)
9da2670 
The .security index is created asynchronously on a cluster startup. This
affects some of the docs YAML tests in a way that they need to account
for the existence of the .security index or wait for the index to be
created and green. This PR disables the feature for docs YAML tests.
Disabling the feature in docs YAML tests will solve the flakiness
without affecting the coverage.

Resolves elastic#122343 Resolves
elastic#121748 Resolves
elastic#121611 Resolves
elastic#121345 Resolves
elastic#121338 Resolves
elastic#121337 Resolves
elastic#121288 Resolves
elastic#121287 Resolves
elastic#121867 Resolves
elastic#122335 Resolves
elastic#122681 Resolves
elastic#121976 Resolves
elastic#123094 Resolves
elastic#123192 Resolves
elastic#122983 Resolves
elastic#124671 Resolves
elastic#124103

(cherry picked from commit cac356a)

# Conflicts:
#	muted-tests.yml
@slobodanadamovic slobodanadamovic mentioned this pull request Mar 13, 2025
Merged
slobodanadamovic added a commit to slobodanadamovic/elasticsearch that referenced this pull request Mar 13, 2025
@slobodanadamovic
Disable queryable built-in feature in docs YAML tests (elastic#124684)
42b3122 
The .security index is created asynchronously on a cluster startup. This
affects some of the docs YAML tests in a way that they need to account
for the existence of the .security index or wait for the index to be
created and green. This PR disables the feature for docs YAML tests.
Disabling the feature in docs YAML tests will solve the flakiness
without affecting the coverage.

Resolves elastic#122343 Resolves
elastic#121748 Resolves
elastic#121611 Resolves
elastic#121345 Resolves
elastic#121338 Resolves
elastic#121337 Resolves
elastic#121288 Resolves
elastic#121287 Resolves
elastic#121867 Resolves
elastic#122335 Resolves
elastic#122681 Resolves
elastic#121976 Resolves
elastic#123094 Resolves
elastic#123192 Resolves
elastic#122983 Resolves
elastic#124671 Resolves
elastic#124103

(cherry picked from commit cac356a)

# Conflicts:
#	muted-tests.yml
@slobodanadamovic
Copy link
Contributor Author

slobodanadamovic commented Mar 13, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x
✅ 9.0
✅ 8.18

Questions ?

Please refer to the Backport tool documentation

@slobodanadamovic slobodanadamovic mentioned this pull request Mar 13, 2025
Merged
slobodanadamovic added a commit to slobodanadamovic/elasticsearch that referenced this pull request Mar 13, 2025
@slobodanadamovic
Disable queryable built-in feature in docs YAML tests (elastic#124684)
8bee2ee 
The .security index is created asynchronously on a cluster startup. This
affects some of the docs YAML tests in a way that they need to account
for the existence of the .security index or wait for the index to be
created and green. This PR disables the feature for docs YAML tests.
Disabling the feature in docs YAML tests will solve the flakiness
without affecting the coverage.

Resolves elastic#122343 Resolves
elastic#121748 Resolves
elastic#121611 Resolves
elastic#121345 Resolves
elastic#121338 Resolves
elastic#121337 Resolves
elastic#121288 Resolves
elastic#121287 Resolves
elastic#121867 Resolves
elastic#122335 Resolves
elastic#122681 Resolves
elastic#121976 Resolves
elastic#123094 Resolves
elastic#123192 Resolves
elastic#122983 Resolves
elastic#124671 Resolves
elastic#124103

(cherry picked from commit cac356a)

# Conflicts:
#	muted-tests.yml
elasticsearchmachine pushed a commit that referenced this pull request Mar 13, 2025
@slobodanadamovic
Disable queryable built-in feature in docs YAML tests (#124684) (#124819
192297f 
)

The .security index is created asynchronously on a cluster startup. This
affects some of the docs YAML tests in a way that they need to account
for the existence of the .security index or wait for the index to be
created and green. This PR disables the feature for docs YAML tests.
Disabling the feature in docs YAML tests will solve the flakiness
without affecting the coverage.

Resolves #122343 Resolves
#121748 Resolves
#121611 Resolves
#121345 Resolves
#121338 Resolves
#121337 Resolves
#121288 Resolves
#121287 Resolves
#121867 Resolves
#122335 Resolves
#122681 Resolves
#121976 Resolves
#123094 Resolves
#123192 Resolves
#122983 Resolves
#124671 Resolves
#124103

(cherry picked from commit cac356a)

# Conflicts:
#	muted-tests.yml
elasticsearchmachine pushed a commit that referenced this pull request Mar 13, 2025
@slobodanadamovic
Disable queryable built-in feature in docs YAML tests (#124684) (#124822
f536f3f 
)

The .security index is created asynchronously on a cluster startup. This
affects some of the docs YAML tests in a way that they need to account
for the existence of the .security index or wait for the index to be
created and green. This PR disables the feature for docs YAML tests.
Disabling the feature in docs YAML tests will solve the flakiness
without affecting the coverage.

Resolves #122343 Resolves
#121748 Resolves
#121611 Resolves
#121345 Resolves
#121338 Resolves
#121337 Resolves
#121288 Resolves
#121287 Resolves
#121867 Resolves
#122335 Resolves
#122681 Resolves
#121976 Resolves
#123094 Resolves
#123192 Resolves
#122983 Resolves
#124671 Resolves
#124103

(cherry picked from commit cac356a)

# Conflicts:
#	muted-tests.yml
elasticsearchmachine pushed a commit that referenced this pull request Mar 13, 2025
@slobodanadamovic
Disable queryable built-in feature in docs YAML tests (#124684) (#124817
ee80f76 
)

The .security index is created asynchronously on a cluster startup. This
affects some of the docs YAML tests in a way that they need to account
for the existence of the .security index or wait for the index to be
created and green. This PR disables the feature for docs YAML tests.
Disabling the feature in docs YAML tests will solve the flakiness
without affecting the coverage.

Resolves #122343 Resolves
#121748 Resolves
#121611 Resolves
#121345 Resolves
#121338 Resolves
#121337 Resolves
#121288 Resolves
#121287 Resolves
#121867 Resolves
#122335 Resolves
#122681 Resolves
#121976 Resolves
#123094 Resolves
#123192 Resolves
#122983 Resolves
#124671 Resolves
#124103

(cherry picked from commit cac356a)

# Conflicts:
#	muted-tests.yml
@richard-dennehy richard-dennehy mentioned this pull request Jul 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@n1v0lg n1v0lg n1v0lg approved these changes

Assignees

@slobodanadamovic slobodanadamovic

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Security/Security Security issues without another label Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] DocsClientYamlTestSuiteIT test {yaml=reference/snapshot-restore/apis/get-snapshot-api/line_751} failing [CI] DocsClientYamlTestSuiteIT test {yaml=reference/rest-api/common-options/line_125} failing [CI] DocsClientYamlTestSuiteIT test {yaml=reference/rest-api/security/invalidate-tokens/line_194} failing [CI] DocsClientYamlTestSuiteIT test {yaml=reference/index-modules/slowlog/line_102} failing [CI] DocsClientYamlTestSuiteIT test {yaml=reference/snapshot-restore/apis/get-snapshot-api/line_357} failing
[CI] DocsClientYamlTestSuiteIT test {yaml=reference/snapshot-restore/apis/get-snapshot-api/line_488} failing [CI] DocsClientYamlTestSuiteIT test {yaml=reference/rest-api/common-options/line_102} failing [CI] DocsClientYamlTestSuiteIT test {yaml=reference/cat/health/cat-health-no-timestamp-example} failing [CI] DocsClientYamlTestSuiteIT test {yaml=reference/cat/allocation/cat-allocation-example} failing [CI] DocsClientYamlTestSuiteIT test {yaml=reference/cat/health/cat-health-example} failing

3 participants

@slobodanadamovic @elasticsearchmachine @n1v0lg