Skip to content

Avoid creating known_fields for every check in Alias #124690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 24, 2025
Merged

Avoid creating known_fields for every check in Alias #124690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6f5814f
avoid creating known_fields for every check
Mar 13, 2025
cf3c960
add changelog
Mar 13, 2025
05d51c1
Merge branch 'main' into optimize/known_fields_creation_in_createIndex
mushao999 Mar 13, 2025
54271c4
Merge branch 'main' into optimize/known_fields_creation_in_createIndex
mushao999 Mar 13, 2025
c76581d
Merge branch 'main' into optimize/known_fields_creation_in_createIndex
dakrone Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/124690.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 124690
summary: Avoid creating known_fields for every check in Alias
area: Indices APIs
type: enhancement
issues: []
18 changes: 9 additions & 9 deletions server/src/main/java/org/elasticsearch/action/admin/indices/alias/Alias.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,14 @@ public class Alias implements Writeable, ToXContentFragment {
private static final ParseField SEARCH_ROUTING = new ParseField("search_routing", "searchRouting", "search-routing");
private static final ParseField IS_WRITE_INDEX = new ParseField("is_write_index");
private static final ParseField IS_HIDDEN = new ParseField("is_hidden");
private static final Set<String> KNOWN_FIELDS = Set.of(
FILTER.getPreferredName(),
ROUTING.getPreferredName(),
INDEX_ROUTING.getPreferredName(),
SEARCH_ROUTING.getPreferredName(),
IS_WRITE_INDEX.getPreferredName(),
IS_HIDDEN.getPreferredName()
);

private String name;

Expand Down Expand Up @@ -234,15 +242,7 @@ public static Alias fromXContent(XContentParser parser) throws IOException {
if (token == XContentParser.Token.FIELD_NAME) {
currentFieldName = parser.currentName();
// check if there are any unknown fields
Set<String> knownFieldNames = Set.of(
FILTER.getPreferredName(),
ROUTING.getPreferredName(),
INDEX_ROUTING.getPreferredName(),
SEARCH_ROUTING.getPreferredName(),
IS_WRITE_INDEX.getPreferredName(),
IS_HIDDEN.getPreferredName()
);
if (knownFieldNames.contains(currentFieldName) == false) {
if (KNOWN_FIELDS.contains(currentFieldName) == false) {
throw new IllegalArgumentException("Unknown field [" + currentFieldName + "] in alias [" + alias.name + "]");
}
} else if (token == XContentParser.Token.START_OBJECT) {
Expand Down
Loading