Skip to content

[9.0] Fix stack trace in ActionListener#assertOnce (#124672) #124712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025
Merged

[9.0] Fix stack trace in ActionListener#assertOnce (#124672) #124712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion server/src/main/java/org/elasticsearch/action/ActionListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,9 @@ static <Response> ActionListener<Response> assertOnce(ActionListener<Response> d

private void assertFirstRun() {
var previousRun = firstCompletion.compareAndExchange(null, new ElasticsearchException("executed already"));
assert previousRun == null : "[" + delegate + "] " + previousRun; // reports the stack traces of both completions
assert previousRun == null
// reports the stack traces of both completions
: new AssertionError("[" + delegate + "]", previousRun);
}

@Override
Expand Down