text_similarity_reranker add a check to check if the reank field exists #124714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TextSimilarityRankBuilder add check field
TextSimilarityRankBuilder add check field
TextSimilarityRankBuilder add check field
elasticsearchmachine
added
v9.1.0
needs:triage
jimczi
added
:Search Relevance/Ranking
elasticsearchmachine
added
the
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
elasticsearchmachine
removed
the
needs:triage
jimczi
removed
the
Team:Search Relevance
elasticsearchmachine
added
the
Team:Search Relevance
benwtrent
reviewed
Mar 17, 2025
| Mapper mapper; | ||
| try { | ||
| mapper = searchContext.indexShard().mapperService().mappingLookup().getMapper(field); | ||
| } catch (NullPointerException e) { |
Member
There was a problem hiding this comment.
We shouldn't use this control flow like this. Why is this throwing an NPE at all? Is it because the mapper service is null or the search context isn't the correct context?
If so, please verify the search context has the required information before making the check. Otherwise, its possible that this gets false positives (e.g. something marked as missing when it actually isn't).
Member
|
closing, seems abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I use text_similarity_reranker, if the field is in correct, I find it return the results, but it don't rerank the result.
I don't know if the rerank work. And I find the results don't match the rerank query, it's hard to debug.
So I add the check to make sure the field exits.