Permanently switch from SecurityManager to Entitlements #124724
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
added
auto-backport
Contributor
|
FWIW I'd vote for a one-liner (or a few-liner) that switches to entitlements everywhere, and leave the code cleanup for another PR once we're sure this won't get reverted. |
Member
+1 |
Contributor
Author
|
No problem, I will close this PR then and have another with the (2, I think) one-liners |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are less minimal that we initially though: I went and removed all the occurrences of
es.entitlements.enabledto leave us in a cleaner situation.If you prefer something more minimal/something that is reversible in e.g. snapshot builds, let me know!
Also: should this be
>breakingor>featureor>enhancement, to be the entitlements issue that has a changelog attached?Relates to ES-10921