Skip to content

Conversation

@idegtiarenko
Copy link
Contributor

@idegtiarenko idegtiarenko commented Mar 13, 2025

This change includes thread pool and thread name in IT logs.
This should allow us to spot if certain code is executed on the wrong threadpool for some reason.

Before:
[2025-03-13T07:56:41,903][INFO ][o.e.c.m.MetadataDeleteIndexService] [node_s0] [test-4/7whRtJ13SFKb_7pAAXQItg] deleting index

After:
[2025-03-13T07:45:14,797][INFO ][o.e.c.m.MetadataDeleteIndexService][node_s2][masterService#updateTask][T#1] [test-15/vMd8iyHjQ22U7kyNI9FYpg] deleting index

This change includes thread pool and thread name in IT logs.
@idegtiarenko idegtiarenko added >test Issues or PRs that are addressing/adding tests Team:Core/Infra Meta label for core/infra team Team:Delivery Meta label for Delivery team v9.1.0 labels Mar 13, 2025
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label and removed Team:Core/Infra Meta label for core/infra team Team:Delivery Meta label for Delivery team labels Mar 13, 2025
@idegtiarenko idegtiarenko requested review from a team March 13, 2025 14:50
@idegtiarenko
Copy link
Contributor Author

idegtiarenko commented Mar 13, 2025

I am not entirely sure about the ownership of this change. Requesting both @elastic/es-core-infra and @elastic/es-delivery to review.

@mosche mosche added :Core/Infra/Logging Log management and logging utilities and removed needs:triage Requires assignment of a team area label labels Mar 14, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Mar 14, 2025
Copy link
Contributor

@mosche mosche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@idegtiarenko idegtiarenko merged commit 35ecbf6 into elastic:main Mar 14, 2025
17 checks passed
@idegtiarenko idegtiarenko deleted the include_thread_name_in_logs branch March 14, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Logging Log management and logging utilities Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants