ESQL: Add capability to prevent failing tests after Starts/EndsWith Lucene pushdown #124764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…With Lucene pushdown
ivancea
added
>test
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
costin
approved these changes
Mar 13, 2025
Member
costin
left a comment
costin
left a comment
There was a problem hiding this comment.
LGTM.
Separately, it's a shame this functionality didn't make it to 8.18 - if it doesn't mess the backporting process I would look into it since the performance implications are significant.
Contributor
Author
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
This was referenced Mar 14, 2025
ivancea
added a commit
to ivancea/elasticsearch
that referenced
this pull request
Mar 14, 2025
…With Lucene pushdown (elastic#124764) Continuation of elastic#124641, after different issues arised. Closes elastic#124693 Closes elastic#124745 The failing BWC tests are checking <8.14 mixed cluster nodes, and SingleValueQuery is sometimes emitting warnings with an empty source.
ivancea
added a commit
that referenced
this pull request
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #124625, after different issues arised.
Closes #124693
Closes #124745
Closes #124829
The failing BWC tests are checking <8.14 mixed cluster nodes, and SingleValueQuery is sometimes emitting warnings with an empty source.
After some investigation, it's locally reproducible (not 100% of the time though). I was looking for some non-serialized Source that we serialized after that version, but I couldn't find anything relevant. So given that this only impacts warnings in old mixed clusters, this change should be enough.