[ML] Migrate model_version to model_id when parsing persistent elser inference endpoints #124769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
>bug
:ml
Collaborator
|
Hi @jonathan-buttner, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
prwhelan
approved these changes
Mar 13, 2025
This was referenced Mar 13, 2025
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
Mar 13, 2025
…inference endpoints (elastic#124769) * Handling model_version for prexisting endpoints * Update docs/changelog/124769.yaml
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
Mar 13, 2025
…inference endpoints (elastic#124769) * Handling model_version for prexisting endpoints * Update docs/changelog/124769.yaml
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
Mar 13, 2025
…inference endpoints (elastic#124769) * Handling model_version for prexisting endpoints * Update docs/changelog/124769.yaml
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
Mar 13, 2025
…inference endpoints (elastic#124769) * Handling model_version for prexisting endpoints * Update docs/changelog/124769.yaml (cherry picked from commit bf53f97) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elasticsearch/ElasticsearchInternalService.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 13, 2025
…inference endpoints (#124769) (#124794) * Handling model_version for prexisting endpoints * Update docs/changelog/124769.yaml (cherry picked from commit bf53f97) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elasticsearch/ElasticsearchInternalService.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124675
This PR addresses an issue where we weren't handling the legacy field
model_versionback from 8.12.In 8.12 we used
model_versionwithinservice_settingsin the persistent inference configuration. In 8.13 we started usingmodel_id. We persist the change somodel_versionmust be handled. In 8.16 we removed the code that handled theelserservice and mapped it toelasticsearch. During that transition we no longer handledmodel_version.This PR adds the handling back.