[Transform] Check alias during update #124773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Transform System Index has been reindexed and aliased, we should check the Transform Update index against the alias when updating the Transform Config.
prwhelan
added
>bug
:ml/Transform
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
prwhelan
commented
Mar 13, 2025
| long lastCheckpoint = currentState.v1().getTransformState().getCheckpoint(); | ||
|
|
||
| // if: the state is stored on the latest index, it does not need an update | ||
| if (currentState.v2().getIndex().equals(TransformInternalIndexConstants.LATEST_INDEX_VERSIONED_NAME)) { |
Member
Author
There was a problem hiding this comment.
LATEST_INDEX_VERSIONED_NAME and LATEST_INDEX_NAME are the same strings:
https://github.com/elastic/elasticsearch/blob/main/x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/transform/transforms/persistence/TransformInternalIndexConstants.java#L39
jonathan-buttner
approved these changes
Mar 13, 2025
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Mar 13, 2025
When the Transform System Index has been reindexed and aliased, we should check the Transform Update index against the alias when updating the Transform Config.
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Mar 13, 2025
When the Transform System Index has been reindexed and aliased, we should check the Transform Update index against the alias when updating the Transform Config.
Collaborator
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 13, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Transform System Index has been reindexed and aliased, we should check the Transform Update index against the alias when updating the Transform Config.
Verified locally:
This change is for ES versions < 9.1 and will be different for 9.1+, since we will pull Index/Alias metadata via the ProjectResolver.