[ML] Allowing deletion of default endpoints while using force=true #124781
+78
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
>non-issue
:ml
jonathan-buttner
changed the title
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
jonathan-buttner
added
the
auto-backport
This was referenced Mar 14, 2025
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
Mar 14, 2025
…lastic#124781) * Allowing deletion of default endpoints and add warning header * Moving to force logic
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
Mar 14, 2025
…lastic#124781) * Allowing deletion of default endpoints and add warning header * Moving to force logic
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
Mar 14, 2025
…lastic#124781) * Allowing deletion of default endpoints and add warning header * Moving to force logic (cherry picked from commit cbfc100) # Conflicts: # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/action/TransportDeleteInferenceEndpointActionTests.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts a decision to prevent deletion of default inference endpoints. We've run into a few instances where deleting inference endpoints has been useful to resolve some bugs. I'm worried that in the future we might be in a situation where we might need to delete a default endpoint to work around a bug.
This PR allows default endpoints to be deleted if the user includes the query parameter
force=true.After a default endpoint is deleted it'll be persisted again when being retrieved if it is not already persisted.