Clarify double-response exception #124809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is confusing to readers to report `Channel is already closed` in reaction to a double-response bug, and this may be interpreted as a networking issue. We're not really closing anything here, and it's a definite logic bug to call `sendResponse()` twice, so this commit clarifies the actual problem in the exception message. Relates ES-10996 Backport of elastic#124706 to `8.x`
DaveCTurner
added
>non-issue
:Distributed Coordination/Network
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is confusing to readers to report
Channel is already closedinreaction to a double-response bug, and this may be interpreted as a
networking issue. We're not really closing anything here, and it's a
definite logic bug to call
sendResponse()twice, so this commitclarifies the actual problem in the exception message.
Relates ES-10996
Backport of #124706 to
8.x