Move some paths in SearchService towards futures and promises #124813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flattening the stacks a little here where we close to never go async and most importantly setting up bigger follow-ups.
original-brownbear
added
>non-issue
:Search Foundations/Search
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
elasticsearchmachine
added
the
Team:Search Foundations
benchaplin
reviewed
Apr 16, 2025
| threadPool | ||
| ); | ||
| final IndexShard shard = getShard(request); | ||
| rewriteAndFetchShardRequest(shard, request, listener.delegateFailure((l, rewritten) -> { |
Contributor
There was a problem hiding this comment.
Is it a bug that rewritten wasn't used in the old code?
Contributor
Author
There was a problem hiding this comment.
Yea but a trivial one funny enough since (for better or for worse ...) we mutate the object in-place. This doesn't change behavior but saves a little GC work by removing needless capturing :)
benchaplin
approved these changes
May 21, 2025
Contributor
benchaplin
left a comment
benchaplin
left a comment
There was a problem hiding this comment.
Sorry for the delay - had to take some more time to learn about rewriteAndFetch. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flattening the stack a little for rewriting, we almost never go async on a rewrite so we can save some stack depth, unnecessary listener wrapping (and resulting retention of heap objects!) here and maybe subjectively make the code a little nicer to read.
A nice side-effect of this change is that it makes profiling much easier to interpret as far as the cost of query rewriting is concerned.
This should be relatively trivial to review, there's no expected behavior changes in this because I actively stayed away from removing callback-style code for ref-counted objects/
SearchPhaseResultinstances.