Simplify and flatten CanMatchPreFilterSearchPhase (#118558) #124876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need the result to be a `SearchPhaseResults`. In fact, there is no reason for it to be a nested class in the first place. Just flatten it into the phase itself and synchronize on `this`. This is just a step on the way to #116881 that makes that PR much easier to review I believe.
original-brownbear
added
backport
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need the result to be a
SearchPhaseResults. In fact, there is no reason for it to be a nested class in the first place. Just flatten it into the phase itself and synchronize onthis.This is just a step on the way to #116881 that makes that PR much easier to review I believe.
back port of #118558