Use child loggers broadly in PolicyManager #124896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prdoyle
added
>non-issue
auto-backport
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Contributor
Author
|
D'oh indeed, Homer, d'oh indeed. |
rjernst
approved these changes
Mar 14, 2025
Member
rjernst
left a comment
rjernst
left a comment
There was a problem hiding this comment.
Looks fine. One nit that could be a followup as it's not performance critical (only happens in case entitlement is being denied) and will likely require some refactoring.
libs/entitlement/src/main/java/org/elasticsearch/entitlement/runtime/policy/PolicyManager.java
Outdated
Show resolved
Hide resolved
Some of our unit tests check for equality of `ModuleEntitlements` objects, and they are entitled to do so (no pun intended).
Contributor
Author
|
FYI this will conflict with #124895. Update: I've resolved the conflict. |
This was referenced Mar 15, 2025
Collaborator
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
Mar 15, 2025
* Use child loggers broadly in PolicyManager * Pass ModuleEntitlements to notEntitled * Store logger name instead of object. Some of our unit tests check for equality of `ModuleEntitlements` objects, and they are entitled to do so (no pun intended). * Alright, let's cache 'em * Memoize at point of creation, not point of use * Explanatory comments
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
Mar 15, 2025
* Use child loggers broadly in PolicyManager * Pass ModuleEntitlements to notEntitled * Store logger name instead of object. Some of our unit tests check for equality of `ModuleEntitlements` objects, and they are entitled to do so (no pun intended). * Alright, let's cache 'em * Memoize at point of creation, not point of use * Explanatory comments
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 15, 2025
* Use child loggers broadly in PolicyManager * Pass ModuleEntitlements to notEntitled * Store logger name instead of object. Some of our unit tests check for equality of `ModuleEntitlements` objects, and they are entitled to do so (no pun intended). * Alright, let's cache 'em * Memoize at point of creation, not point of use * Explanatory comments
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 15, 2025
* Use child loggers broadly in PolicyManager * Pass ModuleEntitlements to notEntitled * Store logger name instead of object. Some of our unit tests check for equality of `ModuleEntitlements` objects, and they are entitled to do so (no pun intended). * Alright, let's cache 'em * Memoize at point of creation, not point of use * Explanatory comments
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 15, 2025
* Use child loggers broadly in PolicyManager * Pass ModuleEntitlements to notEntitled * Store logger name instead of object. Some of our unit tests check for equality of `ModuleEntitlements` objects, and they are entitled to do so (no pun intended). * Alright, let's cache 'em * Memoize at point of creation, not point of use * Explanatory comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to be able to adjust logging independently for different components / modules.