-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add more logging around testStopQueryLocal to see what's going on #124911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -317,7 +317,16 @@ public Stream<Cluster> getClusterStates(Cluster.Status status) { | |
|
|
||
| @Override | ||
| public String toString() { | ||
| return "EsqlExecutionInfo{" + "overallTook=" + overallTook + ", clusterInfo=" + clusterInfo + '}'; | ||
| return "EsqlExecutionInfo{" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I hope this doesn't have any unintended side-effects (it shouldn't, TBH).
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We shouldn't rely on these in tests - or anywhere more important - but if something will pop up I'll fix it. We added some stuff to EsqlExecutionInfo but never updated this, and now I need it for logging. |
||
| + "overallTook=" | ||
| + overallTook | ||
| + ", isPartial=" | ||
| + isPartial | ||
| + ", isStopped=" | ||
| + isStopped | ||
| + ", clusterInfo=" | ||
| + clusterInfo | ||
| + '}'; | ||
| } | ||
|
|
||
| @Override | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any specific reason?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's never actually used. I just noticed it now.