Esql - Add planner information to the profile #124919
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| package org.elasticsearch.xpack.esql.planner; | ||
|
|
||
| import org.elasticsearch.common.io.stream.StreamInput; | ||
| import org.elasticsearch.common.io.stream.StreamOutput; | ||
| import org.elasticsearch.common.io.stream.Writeable; | ||
| import org.elasticsearch.common.xcontent.ChunkedToXContentObject; | ||
| import org.elasticsearch.xcontent.ToXContent; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.Iterator; | ||
|
|
||
| /** | ||
| * Stores profiling information about the query plan. This can be the top level planning on the coordinating node, or the local | ||
| * planning on the data nodes. | ||
| */ | ||
| public class PlannerProfile implements Writeable, ChunkedToXContentObject { | ||
|
Contributor
There was a problem hiding this comment. It looks like this is still work in progress, but I would suggest we try to design it to be a record from the very beginning |
||
|
|
||
| public static final PlannerProfile EMPTY = new PlannerProfile(); | ||
|
|
||
| private final boolean isLocalPlanning; | ||
|
|
||
| public static PlannerProfile readFrom(StreamInput in) throws IOException { | ||
| // NOCOMMIT | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| public PlannerProfile() { | ||
| // NOCOMMIT | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| @Override | ||
| public void writeTo(StreamOutput out) throws IOException { | ||
| // NOCOMMIT | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| @Override | ||
| public Iterator<? extends ToXContent> toXContentChunked(ToXContent.Params params) { | ||
| // NOCOMMIT | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| package org.elasticsearch.xpack.esql.plugin; | ||
|
|
||
| import org.elasticsearch.common.io.stream.StreamInput; | ||
| import org.elasticsearch.common.io.stream.StreamOutput; | ||
| import org.elasticsearch.common.io.stream.Writeable; | ||
| import org.elasticsearch.compute.operator.DriverProfile; | ||
| import org.elasticsearch.xpack.esql.planner.PlannerProfile; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.List; | ||
|
|
||
| /** | ||
| * Holds the collection of driver profiles and query planning profiles from the individual nodes processing the query. | ||
| */ | ||
| public class CollectedProfiles implements Writeable { | ||
not-napoleon marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| public static final CollectedProfiles EMPTY = new CollectedProfiles(List.of(), List.of()); | ||
|
|
||
| private List<DriverProfile> driverProfiles; | ||
| private List<PlannerProfile> plannerProfiles; | ||
|
|
||
| public CollectedProfiles(List<DriverProfile> driverProfiles, List<PlannerProfile> plannerProfiles) { | ||
| this.driverProfiles = driverProfiles; | ||
| this.plannerProfiles = plannerProfiles; | ||
| } | ||
|
|
||
| public CollectedProfiles(StreamInput in) throws IOException { | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| public void writeTo(StreamOutput out) throws IOException { | ||
|
|
||
| } | ||
|
|
||
| public List<DriverProfile> getDriverProfiles() { | ||
| return driverProfiles; | ||
| } | ||
|
|
||
| public List<PlannerProfile> getPlannerProfiles() { | ||
| return plannerProfiles; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: I wonder if we could make this a record?
This way we could avoid custom equals/hashCode/toString.
Merge could be updated to return a new instance instead of mutating this one