Guard checking master node watching for file settings #124960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In tests for file settings the master node is started async. The assertion that the master node's file setting service is watching for changes must then wait until the async thread has started. Some tests already do that. This PR adjusts the remaining tests to similarly wait for the master node's watcher thread to start. closes elastic#124279
rjernst
added
>test
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 17, 2025
This was referenced Mar 17, 2025
Collaborator
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 17, 2025
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 17, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 17, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 17, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 17, 2025
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tests for file settings the master node is started async. The assertion that the master node's file setting service is watching for changes must then wait until the async thread has started. Some tests already do that. This PR adjusts the remaining tests to similarly wait for the master node's watcher thread to start.
closes #124279