Don't generate stacktrace in TaskCancelledException #125002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>non-issue
:Search/Search
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
benwtrent
approved these changes
Mar 17, 2025
Member
benwtrent
left a comment
benwtrent
left a comment
There was a problem hiding this comment.
❤️
This should be marked as a bug IMO and this is a bug fix.
Collaborator
|
Hi @iverase, I've created a changelog YAML for you. |
Contributor
Author
|
Let's make it a bug then. |
Member
|
For the record, this change does not hurt and it's a good idea, but after #118266 , where we removed stacktraces for all exceptions returned back to the coord node, I am not so sure it's going to practically make a huge difference. |
javanna
added
:Search Foundations/Search
elasticsearchmachine
added
Team:Search Foundations
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
iverase
added
the
auto-backport
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Mar 17, 2025
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Mar 17, 2025
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Mar 17, 2025
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Mar 17, 2025
# Conflicts: # modules/aggregations/src/internalClusterTest/java/org/elasticsearch/aggregations/bucket/SearchCancellationIT.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 17, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 17, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 17, 2025
…125031) * Don't generate stacktrace in TaskCancelledException (#125002) # Conflicts: # modules/aggregations/src/internalClusterTest/java/org/elasticsearch/aggregations/bucket/SearchCancellationIT.java * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 17, 2025
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to expend cycles and heap on it.