Enable and fix testFailOnUnavailableShards #125020
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
>non-issue
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
idegtiarenko
commented
Mar 17, 2025
| var shardId = group.shardId(); | ||
| if (concreteIndices.contains(shardId.getIndexName()) == false) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
This condition was causing testFailOnUnavailableShards failure as concreteIndices did not contain unavailable index. It is present in one of the groups with empty allocatedNodes
There was a problem hiding this comment.
I think we should not remove this. If a new index is created between field-caps and search_shards with conflicting mappings, the query can fail.
|
Closing in favor of #125096 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables
testFailOnUnavailableShards.This was originally pointing to the issue that is closed.
After enabling it I noticed that we were silently searching only in available shards.
This change attempts to fix this test.