Skip to content

Conversation

@arpadkiraly
Copy link
Contributor

Re ES-10767, removing the @UpdateForV9 annotation entirely prior to the 9.0.0 release.

@arpadkiraly arpadkiraly added :Core/Infra/Core Core issues without another label >refactoring Team:Core/Infra Meta label for core/infra team auto-backport Automatically create backport pull requests when merged v9.0.0 v9.0.1 v9.1.0 labels Mar 17, 2025
@arpadkiraly
Copy link
Contributor Author

Note that CI is expected to fail as long as there exists at least 1 reference or usage of the @UpdateForV9 annotation in the repository.
There is 1 known case left:

import org.elasticsearch.core.UpdateForV9;
which should be addressed in #124798.

@arpadkiraly arpadkiraly marked this pull request as ready for review March 18, 2025 10:36
@arpadkiraly arpadkiraly requested a review from a team as a code owner March 18, 2025 10:36
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@arpadkiraly
Copy link
Contributor Author

Note that CI is expected to fail as long as there exists at least 1 reference or usage of the @UpdateForV9 annotation in the repository. There is 1 known case left:

import org.elasticsearch.core.UpdateForV9;

which should be addressed in #124798.

This usage owned by the Docs team got removed, so this PR should be good to go.

Copy link
Contributor

@mosche mosche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍
sorry, missed you've already updated the PR with above mentioned change further above

@arpadkiraly arpadkiraly merged commit 30dd38b into main Mar 18, 2025
18 checks passed
@arpadkiraly arpadkiraly deleted the arpadkiraly-remove-updateforv9-entirely branch March 18, 2025 11:52
arpadkiraly added a commit to arpadkiraly/elasticsearch that referenced this pull request Mar 18, 2025
* Delete libs/core/src/main/java/org/elasticsearch/core/UpdateForV9.java

* Remove UpdateForV9 annotation in ConsumeProcessor.java
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.0

elasticsearchmachine pushed a commit that referenced this pull request Mar 18, 2025
* Delete libs/core/src/main/java/org/elasticsearch/core/UpdateForV9.java

* Remove UpdateForV9 annotation in ConsumeProcessor.java

Co-authored-by: Moritz Mack <[email protected]>
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
* Delete libs/core/src/main/java/org/elasticsearch/core/UpdateForV9.java

* Remove UpdateForV9 annotation in ConsumeProcessor.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Core/Infra/Core Core issues without another label >refactoring Team:Core/Infra Meta label for core/infra team v9.0.0 v9.0.1 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants