-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add Apache Arrow as a bulk ingestion format #125040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
swallez
wants to merge
36
commits into
elastic:main
Choose a base branch
from
swallez:bulk-arrow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 21 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
860b20c
Add Apache Arrow as a bulk ingestion format
swallez be7cffc
Update docs/changelog/125040.yaml
swallez d23ba11
[CI] Auto commit changes from spotless
5dfdbd8
useDefaultDistribution is not needed anymore
swallez e1af882
Fix Arrow lib license files
swallez 604da53
Remove licence files now provided by the server module via libs:arrow
swallez af76ead
Fix server entitlements
swallez 5510ae8
Fix forbiddanApis task
swallez 57186c8
[CI] Auto commit changes from spotless
5952435
Fix server entitlements (hopefully for good)
swallez 259ed8a
[CI] Auto commit changes from spotless
40c3176
Fix thirdPartyAudit
swallez 21cb8ff
Refactor: move Arrow bulk out of the server module. This causes too m…
swallez 8cca7e2
[CI] Auto commit changes from spotless
86ab390
Move Arrow-related security policy to the Arrow module
swallez 44a1b64
Fix API name, remove test warning
swallez f2036d3
Merge branch 'main' into bulk-arrow
swallez 181e78a
Re-add tests that were lost in the refactoring
swallez d686e88
Add support for timestamps, more tests
swallez 98e2e7e
Return an Arrow response
swallez 726df62
merge main
swallez 923c7e8
Merge remote-tracking branch 'upstream/main' into bulk-arrow
swallez c20bccf
Bump Arrow version
swallez 68779ce
wip
swallez cb72323
Refactor, add tests
swallez f920cfb
Merge remote-tracking branch 'upstream/main' into bulk-arrow
swallez a39e113
Add support for non-streamed requests, plus minor fixes
swallez 1b14d72
Fix verification-metadata file
swallez 1e93bf4
Fix style
swallez a9f9ee3
Do not publish libs/arrow
swallez 93cbede
Merge branch 'main' into bulk-arrow
swallez ee0d9eb
Merge branch 'main' into bulk-arrow
swallez c490de0
Ensure histogram is created only once (causes an exception otherwise)
swallez 5d7dd92
Fix XContentBuffer
swallez bf48259
Fix test
swallez de6c895
Merge branch 'main' into bulk-arrow
swallez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| pr: 125040 | ||
| summary: Add Apache Arrow as a bulk ingestion format | ||
| area: CRUD | ||
| type: enhancement | ||
| issues: [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the "Elastic License | ||
| * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side | ||
| * Public License v 1"; you may not use this file except in compliance with, at | ||
| * your election, the "Elastic License 2.0", the "GNU Affero General Public | ||
| * License v3.0 only", or the "Server Side Public License, v 1". | ||
| */ | ||
|
|
||
| // Notes: | ||
| // - additional JVM arguments are added to distribution/src/config/jvm.options and ElasticsearchTestBasePlugin | ||
| // - additional permissions are added to server/src/main/resources/org/elasticsearch/bootstrap/security.policy | ||
|
|
||
| import org.elasticsearch.gradle.internal.precommit.CheckForbiddenApisTask | ||
|
|
||
| apply plugin: 'elasticsearch.build' | ||
| apply plugin: 'elasticsearch.publish' | ||
|
|
||
| var arrowVersion = "18.2.0" | ||
|
|
||
| dependencies { | ||
| //implementation(project(":libs:x-content")) | ||
|
|
||
| // jackson-core is provided by :libs:x-content:impl. If declared here, there's a module issue that prevents ES from starting: | ||
| // | ||
| // fatal exception while booting Elasticsearch java.lang.IllegalAccessError: class org.elasticsearch.xcontent.provider.json.JsonXContentImpl (in module org.elasticsearch.xcontent.impl) cannot access class com.fasterxml.jackson.core.JsonFactoryBuilder (in unnamed module @0x4727e5fc) because module org.elasticsearch.xcontent.impl does not read unnamed module @0x4727e5fc | ||
| // at [email protected]/org.elasticsearch.xcontent.provider.json.JsonXContentImpl.<clinit>(JsonXContentImpl.java:50) | ||
| // at [email protected]/org.elasticsearch.xcontent.provider.XContentProviderImpl$2.XContent(XContentProviderImpl.java:54) | ||
| // at [email protected]/org.elasticsearch.xcontent.json.JsonXContent.<clinit>(JsonXContent.java:37) | ||
| // at [email protected]/org.elasticsearch.xcontent.XContentType.<clinit>(XContentType.java:28) | ||
| // at [email protected]/org.elasticsearch.common.settings.Setting.arrayToParsableString(Setting.java:1883) | ||
| //implementation(project(":libs:x-content:impl")) | ||
|
|
||
| // arrow-vector | ||
| api("org.apache.arrow:arrow-vector:${arrowVersion}") | ||
| api("com.fasterxml.jackson.core:jackson-core:${versions.jackson}") | ||
| api("com.fasterxml.jackson.core:jackson-annotations:${versions.jackson}") | ||
| api("com.fasterxml.jackson.core:jackson-databind:${versions.jackson}") | ||
| api("com.fasterxml.jackson.datatype:jackson-datatype-jsr310:${versions.jackson}") | ||
|
|
||
| api("com.google.flatbuffers:flatbuffers-java:24.3.25") | ||
| api("commons-codec:commons-codec:${versions.commonscodec}") // Arrow 18 -> commons-codec 1.17.1 | ||
| api("org.slf4j:slf4j-api:${versions.slf4j}") | ||
| api("org.immutables:value-annotations:2.10.1") // provided dependency | ||
|
|
||
| // arrow-format | ||
| api("org.apache.arrow:arrow-format:${arrowVersion}") | ||
| // also depends on flatbuffers | ||
|
|
||
| // arrow-memory-core | ||
| api("org.apache.arrow:arrow-memory-core:${arrowVersion}") | ||
| api("com.google.errorprone:error_prone_annotations:2.31.0") // provided dependency | ||
| api('org.checkerframework:checker-qual:3.48.1') // provided dependency | ||
| // also depends on value-annotations (provided dependency) | ||
|
|
||
| // arrow-memory-unsafe | ||
| api("org.apache.arrow:arrow-memory-unsafe:${arrowVersion}") | ||
| // also depends on value-annotations (provided dependency) | ||
|
|
||
| testImplementation(project(":test:framework")) { | ||
| exclude group: 'org.elasticsearch', module: 'arrow' | ||
| } | ||
| } | ||
|
|
||
| tasks.named("dependencyLicenses").configure { | ||
| mapping from: /jackson-.*/, to: 'jackson' | ||
| mapping from: /arrow-.*/, to: 'arrow' | ||
| mapping from: /value-annotations.*/, to: 'org-immutables' | ||
| } | ||
|
|
||
| tasks.named("thirdPartyAudit").configure { | ||
| ignoreViolations( | ||
| 'org.apache.arrow.memory.util.MemoryUtil', | ||
| 'org.apache.arrow.memory.util.MemoryUtil$1', | ||
| ) | ||
| } | ||
|
|
||
| tasks.withType(CheckForbiddenApisTask).configureEach { | ||
| // Remove server signatures as they will fail on classes missing in this lib's classpath, | ||
| // like org.apache.lucene.util.IOUtils | ||
| replaceSignatureFiles('jdk-signatures') | ||
| } | ||
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| Apache Commons Codec | ||
| Copyright 2002-2015 The Apache Software Foundation | ||
|
|
||
| This product includes software developed at | ||
| The Apache Software Foundation (http://www.apache.org/). | ||
|
|
||
| src/test/org/apache/commons/codec/language/DoubleMetaphoneTest.java | ||
| contains test data from http://aspell.net/test/orig/batch0.tab. | ||
| Copyright (C) 2002 Kevin Atkinson ([email protected]) | ||
|
|
||
| =============================================================================== | ||
|
|
||
| The content of package org.apache.commons.codec.language.bm has been translated | ||
| from the original php source code available at http://stevemorse.org/phoneticinfo.htm | ||
| with permission from the original authors. | ||
| Original source copyright: | ||
| Copyright (c) 2008 Alexander Beider & Stephen P. Morse. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.