- 
                Notifications
    
You must be signed in to change notification settings  - Fork 25.6k
 
Remove disable assertion jvm args from bwc/mixed cluster setups. #125074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Update `-da:org.elasticsearch.index.mapper.DocumentMapper` and `-da:org.elasticsearch.index.mapper.MapperService` from cluster setup. Given that elastic#122606 is now backported to the 8.18 branch.
e5f85e0    to
    b28da36      
    Compare
  
    | 
           Pinging @elastic/es-storage-engine (Team:StorageEngine)  | 
    
              
                    dnhatn
  
              
              approved these changes
              
                  
                    Mar 18, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
          💔 Backport failed
 You can use sqren/backport to manually backport by running   | 
    
    
  martijnvg 
      added a commit
        to martijnvg/elasticsearch
      that referenced
      this pull request
    
      Mar 19, 2025 
    
    
      
  
    
      
    
  
Backporting elastic#125074 to 9.0 branch. Remove `-da:org.elasticsearch.index.mapper.DocumentMapper` and `-da:org.elasticsearch.index.mapper.MapperService` from mixed cluster/bwc cluster setups. Given that elastic#122606 is now backported to the 8.18 branch.
  This was referenced Mar 19, 2025 
      
    
  martijnvg 
      added a commit
        to martijnvg/elasticsearch
      that referenced
      this pull request
    
      Mar 19, 2025 
    
    
      
  
    
      
    
  
Backporting elastic#125074 to 8.x branch. Remove `-da:org.elasticsearch.index.mapper.DocumentMapper` and `-da:org.elasticsearch.index.mapper.MapperService` from mixed cluster/bwc cluster setups. Given that elastic#122606 is now backported to the 8.18 branch.
    
  smalyshev 
      pushed a commit
        to smalyshev/elasticsearch
      that referenced
      this pull request
    
      Mar 21, 2025 
    
    
      
  
    
      
    
  
…stic#125074) Remove `-da:org.elasticsearch.index.mapper.DocumentMapper` and `-da:org.elasticsearch.index.mapper.MapperService` from mixed cluster/bwc cluster setups. Given that elastic#122606 is now backported to the 8.18 branch.
    
  omricohenn 
      pushed a commit
        to omricohenn/elasticsearch
      that referenced
      this pull request
    
      Mar 28, 2025 
    
    
      
  
    
      
    
  
…stic#125074) Remove `-da:org.elasticsearch.index.mapper.DocumentMapper` and `-da:org.elasticsearch.index.mapper.MapperService` from mixed cluster/bwc cluster setups. Given that elastic#122606 is now backported to the 8.18 branch.
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    auto-backport
  Automatically create backport pull requests when merged 
  
    backport pending
  
    :StorageEngine/Mapping
  The storage related side of mappings 
  
    Team:StorageEngine
  
    >test
  Issues or PRs that are addressing/adding tests 
  
    test-full-bwc
  Trigger full BWC version matrix tests 
  
    v8.19.0
  
    v9.0.0
  
    v9.1.0
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Remove
-da:org.elasticsearch.index.mapper.DocumentMapperand-da:org.elasticsearch.index.mapper.MapperServicefrom cluster setup. Given that #122606 is now backported to the 8.18 branch.